🐛 Ensure that no-token case is actually logged #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTR I noticed this unreachable path while working on #464. |
|
I think I saw some of those red tests being flaky locally for some reason. I'm going to wait until #464 is in and rebase to see if that'll be enough. |
Prior to this patch, there was an unreachable code path that seems to have been intended for marking the case when no token is provided with the `"NOTOKEN"` string in the debug log output. However the logic behind choosing to show it contained two opposite checks. Said place in the logging utils, didn't have any coverage either. This change updates the code to make all of its branches reachable. Moreover, it adds test cases for all the branches that remain in the implementation.
webknjaz
force-pushed
the
bugfixes/token-logging-coverage
branch
from
a06cbdf
to
1772372
Compare
|
🤞 |
|
😮💨 I'll look into it later.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, there was an unreachable code path that seems to have been intended for marking the case when no token is provided with the
"NOTOKEN"string in the debug log output. However the logic behind choosing to show it contained two opposite checks. Said place in the logging utils, didn't have any coverage either.This change updates the code to make all of its branches reachable. Moreover, it adds test cases for all the branches that remain in the implementation.