fix: accept tokenless value from branch instead of env var #475

joseph-sentry · 2024-07-15T17:37:41Z

depends on: codecov/codecov-action#1511
fixes: codecov/engineering-team#2065

github-actions · 2024-07-15T17:38:17Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:38:21Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:38:23Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:38:27Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:38:32Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

codecov · 2024-07-15T17:38:54Z

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
2094	3	2091	0

View the top 3 failed tests by shortest run time

api.temp.calculator.test_calculator test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

api.temp.calculator.test_calculator test_divide

Stack Traces | 0.001s run time

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

github-actions · 2024-07-15T17:39:26Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:39:26Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:39:26Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:39:27Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T17:39:38Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-31T18:20:17Z

❌ Failed Test Results:

Completed 694 tests with 1 failed, 693 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-31T18:20:19Z

❌ Failed Test Results:

Completed 694 tests with 1 failed, 693 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-31T18:20:20Z

❌ Failed Test Results:

Completed 694 tests with 1 failed, 693 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-31T18:20:27Z

❌ Failed Test Results:

Completed 694 tests with 1 failed, 693 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-31T18:20:30Z

❌ Failed Test Results:

Completed 694 tests with 1 failed, 693 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

matt-codecov · 2024-08-08T22:49:08Z

codecov_cli/services/commit/__init__.py

-    tokenless = os.environ.get("TOKENLESS")
-    if tokenless:
+    if not token and branch and ":" in branch:
        headers = None  # type: ignore
-        branch = tokenless  # type: ignore
        logger.info("The PR is happening in a forked repo. Using tokenless upload.")
    else:
        headers = get_token_header_or_fail(token)


strictly speaking, we no longer need any of this logic anymore. we just send whatever we have for the token and the branch, and the API will return a 401 if it's not allowed

the logs may still be helpful, so maybe change to:

if not token: if branch and ":" in branch: logger.info("Creating a commit on an unprotected branch") else: logger.warning("Token is missing, but branch is missing or protected") headers = get_token_header(token)

github-actions · 2024-09-04T19:09:49Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-04T19:09:50Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-04T19:09:55Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-04T19:09:59Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-04T19:10:06Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-05T13:35:04Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-05T13:35:06Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-05T13:35:17Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Signed-off-by: joseph-sentry <[email protected]>

just pass through token and branch and let the API handle the failure if the token is undefined and the branch is protected

github-actions · 2024-09-05T13:41:13Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-05T13:41:17Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-05T13:41:34Z

❌ Failed Test Results:

Completed 696 tests with 1 failed, 695 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-26T13:55:35Z

❌ Failed Test Results:

Completed 698 tests with 2 failed, 696 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
tests.services.commit.test_commit_service::test_commit_sender_with_forked_repo_bad_branch

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7fb05bbed2d0&gt;

    def test_commit_sender_with_forked_repo_bad_branch(mocker):
        mocked_response = mocker.patch(
            &quot;codecov_cli.services.commit.send_post_request&quot;,
            return_value=mocker.MagicMock(status_code=200, text=&quot;success&quot;),
        )
    
&gt;       _res = send_commit_data(
            &quot;commit_sha&quot;,
            &quot;parent_sha&quot;,
            &quot;1&quot;,
            &quot;branch&quot;,
            &quot;codecov::::codecov-cli&quot;,
            None,
            &quot;github&quot;,
            None,
        )
E       TypeError: send_commit_data() missing 1 required positional argument: &apos;args&apos;

.../services/commit/test_commit_service.py:185: TypeError

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-26T13:55:47Z

❌ Failed Test Results:

Completed 698 tests with 2 failed, 696 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
tests.services.commit.test_commit_service::test_commit_sender_with_forked_repo_bad_branch

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7fabce774760&gt;

    def test_commit_sender_with_forked_repo_bad_branch(mocker):
        mocked_response = mocker.patch(
            &quot;codecov_cli.services.commit.send_post_request&quot;,
            return_value=mocker.MagicMock(status_code=200, text=&quot;success&quot;),
        )
    
&gt;       _res = send_commit_data(
            &quot;commit_sha&quot;,
            &quot;parent_sha&quot;,
            &quot;1&quot;,
            &quot;branch&quot;,
            &quot;codecov::::codecov-cli&quot;,
            None,
            &quot;github&quot;,
            None,
        )
E       TypeError: send_commit_data() missing 1 required positional argument: &apos;args&apos;

.../services/commit/test_commit_service.py:185: TypeError

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-26T13:55:56Z

❌ Failed Test Results:

Completed 698 tests with 2 failed, 696 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Testsuite:
tests.services.commit.test_commit_service::test_commit_sender_with_forked_repo_bad_branch

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7f0ca09121b0&gt;

    def test_commit_sender_with_forked_repo_bad_branch(mocker):
        mocked_response = mocker.patch(
            &quot;codecov_cli.services.commit.send_post_request&quot;,
            return_value=mocker.MagicMock(status_code=200, text=&quot;success&quot;),
        )
    
&gt;       _res = send_commit_data(
            &quot;commit_sha&quot;,
            &quot;parent_sha&quot;,
            &quot;1&quot;,
            &quot;branch&quot;,
            &quot;codecov::::codecov-cli&quot;,
            None,
            &quot;github&quot;,
            None,
        )
E       TypeError: send_commit_data() missing 1 required positional argument: &apos;args&apos;

.../services/commit/test_commit_service.py:185: TypeError

github-actions · 2024-09-26T14:46:05Z

❌ Failed Test Results:

Completed 698 tests with 1 failed, 697 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-26T14:46:06Z

❌ Failed Test Results:

Completed 698 tests with 1 failed, 697 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-09-26T14:46:23Z

❌ Failed Test Results:

Completed 698 tests with 1 failed, 697 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

joseph-sentry force-pushed the joseph/fix-tokenless branch from b0dd421 to 691e159 Compare July 31, 2024 18:19

joseph-sentry requested a review from a team July 31, 2024 18:19

giovanni-guidini previously approved these changes Aug 1, 2024

View reviewed changes

matt-codecov mentioned this pull request Aug 8, 2024

feat: pass tokenless value as branch override codecov/codecov-action#1511

Merged

matt-codecov reviewed Aug 8, 2024

View reviewed changes

matt-codecov mentioned this pull request Aug 27, 2024

Tweak how CLI gets the branch name for tokenless codecov/engineering-team#2065

Open

joseph-sentry dismissed giovanni-guidini’s stale review via 4250717 September 5, 2024 13:34

joseph-sentry added 3 commits September 5, 2024 09:40

fix: accept tokenless value from branch instead of env var

da407ca

Signed-off-by: joseph-sentry <[email protected]>

fix: check if not token for tokenless

172ac6f

Signed-off-by: joseph-sentry <[email protected]>

fix: address feedback

24daf24

just pass through token and branch and let the API handle the failure if the token is undefined and the branch is protected

joseph-sentry force-pushed the joseph/fix-tokenless branch from 4250717 to 24daf24 Compare September 5, 2024 13:40

Merge branch 'main' into joseph/fix-tokenless

02fab9b

fix: tests

bf44167

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: accept tokenless value from branch instead of env var #475

fix: accept tokenless value from branch instead of env var #475

joseph-sentry commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

codecov bot commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

matt-codecov Aug 8, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

fix: accept tokenless value from branch instead of env var #475

Are you sure you want to change the base?

fix: accept tokenless value from branch instead of env var #475

Conversation

joseph-sentry commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

codecov bot commented Jul 15, 2024 • edited Loading

❌ 3 Tests Failed:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 31, 2024

❌ Failed Test Results:

github-actions bot commented Jul 31, 2024

❌ Failed Test Results:

github-actions bot commented Jul 31, 2024

❌ Failed Test Results:

github-actions bot commented Jul 31, 2024

❌ Failed Test Results:

github-actions bot commented Jul 31, 2024

❌ Failed Test Results:

matt-codecov Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024

❌ Failed Test Results:

github-actions bot commented Sep 4, 2024

❌ Failed Test Results:

github-actions bot commented Sep 4, 2024

❌ Failed Test Results:

github-actions bot commented Sep 4, 2024

❌ Failed Test Results:

github-actions bot commented Sep 4, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 5, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

github-actions bot commented Sep 26, 2024

❌ Failed Test Results:

codecov bot commented Jul 15, 2024 •

edited

Loading