Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Java JUnit conventions into account when detecting test files to upload #550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonardehrenfried
Copy link

I've just discovered the test upload feature - great work!

I've tried it on a Maven/Java project and the majority of my test files were not detected because Maven/JUnit/Surefire prefixes them with TEST and not test.

https://github.com/opentripplanner/OpenTripPlanner/actions/runs/11665161617/job/32477225744

For this reason I'm adding this to the default patterns for Junit test uploads.

@rohan-at-sentry
Copy link
Contributor

@leonardehrenfried thanks for the PR. I also wanted to point out that you can set the regex to something that works for you using the files param (assuming you're using the Test-results action. For more, see docs - https://docs.codecov.com/docs/test-analytics-beta#troubleshooting

Out of curiosity, how did you come across this feature? Feature discovery is something we're looking to better optimize, so your thoughts would be helpful

@leonardehrenfried
Copy link
Author

leonardehrenfried commented Nov 4, 2024

I will try setting files in the action. While the troubleshooting guide you looked at gives me a good idea how to do it, I looked at the docs of this repo and there it's not quite so clear. Do you welcome doc PRs?

I discovered this feature when a new tab appeared on my coverage report page:

Screenshot From 2024-11-04 21-36-19

@rohan-at-sentry
Copy link
Contributor

Thanks @leonardehrenfried - I'm assuming you mean PR on the https://github.com/codecov/test-results-action? If so, yes PRs totally welcome.

@rohan-at-sentry
Copy link
Contributor

@joseph-sentry can you review this PR please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants