test(cli): improve TestServer/SpammyLogs line count #16814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing for me in dogfood (23 > 20).
I noticed that 1) the message for install.sh had changed and 2) we were counting lines incorrectly because of how the pty can move the cursor.
I also added the tf newer than expected to the ignore list, since it isn't something we should normally print, and if we do it's legit.
This is what the test log output now looks like: