Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windsurf Desktop module #353

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

cholojuanito
Copy link

This PR adds Windsurf as another option for one click opening via the Coder Remote extension.

@matifali
Copy link
Member

matifali commented Nov 27, 2024

When I try to use the module, I get that the Coder extension is not available in the marketplace. Coder currently depends on vscode-remote extension which is only available in the VSCode marketplace. This is the reason Coder itself is not available in OpenVSX marketplace.

image

Related: coder/vscode-coder#387


Edit: If I manually install the Coder Extension using the VSIX, I get

image

Edit 2: Looks like they have some custom implementation for SSH hosts. Maybe you should request their team to add support for Coder.

@cholojuanito
Copy link
Author

cholojuanito commented Nov 27, 2024

I see. Windsurf must have their own flavor of a remote connection extension then. Sounds like coder would not be able to support it without changing code on their end right?

resource "coder_app" "windsurf" {
agent_id = var.agent_id
external = true
icon = "/icon/windsurf.svg"
Copy link
Member

@matifali matifali Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this to work we need the icon to be in https://github.com/coder/coder/tree/main/site/static/icon too.

Comment on lines +5 to +6
maintainer_github: coder
verified: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cholojuanito are you affiliated with windsurf? If yes we can add a partner_github. Send me an email to discuss this further.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not, just enjoy the IDE and figured it would be easy to make one of these integrations since it's a vscode based project. But I guess the licenses around using the official extensions marketplace might make things more difficult

@matifali matifali requested a review from code-asher November 27, 2024 18:05
@matifali
Copy link
Member

@code-asher may have some ideas on how we can make it work.

@code-asher
Copy link
Member

Might have to distribute a separate vsix without the dependency.

@matifali
Copy link
Member

We do support WIndSurf now as we have removed the ms-remote-ssh dependency.
coder/vscode-coder#441

@cholojuanito
Copy link
Author

Awesome! Thanks for the excellent support

@matifali
Copy link
Member

@cholojuanito are you interested in reworking on the PR?
I have a few suggestion

  1. rename to windsurf
  2. copy all functionality from cursor and vscode-desktop modules

Thanks

@cholojuanito
Copy link
Author

Yeah I could take a look this weekend

@matifali
Copy link
Member

We are live on OpenVSX 🎉
https://open-vsx.org/extension/coder/coder-remote

The module should be easy to do now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants