fix: immediately rebind after WSAECONNRESET #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This alone doesn't close coder/coder#14549 |
spikecurtis
reviewed
Sep 16, 2024
| // doesn't keep trying to read packets from us. | ||
| connErr = permanentNetError{error: err} | ||
| c.logf("magicsock: receive: rebind required due to socket reset: %v", err) | ||
| c.Rebind() |
There was a problem hiding this comment.
The docs for Rebind() say that we need to call ReSTUN() after rebinding.
wgengine/magicsock/magicsock.go
Outdated
| connErr = permanentNetError{error: err} | ||
| c.logf("magicsock: receive: rebind required due to socket reset: %v", err) | ||
| c.Rebind() | ||
| return 0, connErr |
There was a problem hiding this comment.
Looking into this more, I don't think a permanent error is the right thing when combined with rebinding. The magicsock rebinds under the covers as far as the Wireguard device is concerned. If we return a permanent error, Wireguard will stop reading from this function, and has to be stopped and restarted. I guess just return the original error so it gets logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailscale is setting the socket option that prevents this from occurring, but somehow it happened anyways. Since it's a permanent error we now tell wireguard to give up and we call conn.Rebind.
relates to coder/coder#14549