Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a workspace preset datasource #332

Merged
merged 10 commits into from
Feb 4, 2025
Merged

feat: add a workspace preset datasource #332

merged 10 commits into from
Feb 4, 2025

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Jan 28, 2025

This pull request adds data "coder_workspace_preset" {}

Basic validation is done when the data source is read, but cross validation against coder_parameter data sources happens in the provisioner in coder/coder.

Once merged into main, we'll need to backport to v1.0.5 and bump the dependency in coder/coder, because we rely on types in this provider in the coder provisioner.

Copy link
Contributor Author

@SasSwart SasSwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review:

@SasSwart SasSwart requested a review from dannykopping January 29, 2025 15:28
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about the idiomatic approach to validation but otherwise LGTM
Feel free to ignore the nits.

@SasSwart SasSwart merged commit d7d2b70 into main Feb 4, 2025
8 checks passed
@SasSwart SasSwart deleted the jjs/presets branch February 4, 2025 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants