Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in architecture matching #46

Closed
wants to merge 2 commits into from
Closed

Fix typo in architecture matching #46

wants to merge 2 commits into from

Conversation

angrycub
Copy link

@angrycub angrycub commented Oct 2, 2024

The select_archive_format function was looking for darwin-* and windows-* where the detect_platform function was producing os_arch shaped answers.

Fixes #32 and #39

@coadler
Copy link
Member

coadler commented Oct 2, 2024

Oops, just fixed this in main 74ff5d3

@angrycub
Copy link
Author

angrycub commented Oct 2, 2024

No worries. Just happened to see it while I was here.

@angrycub angrycub closed this Oct 2, 2024
@angrycub angrycub deleted the angrycub/issue39 branch October 2, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install script doesn't work correctly with ubuntu
2 participants
@angrycub @coadler