Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use constantine sha256 for codex tree hashing #1168

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

munna0908
Copy link
Contributor

Based on the latest benchmarks, Constantine SHA256 demonstrates excellent performance for hashing 32-byte payloads. This PR updates the CodexTree hashing algorithm by replacing mhash 256 with Constantine SHA256.

@munna0908 munna0908 requested review from dryajov and gmega March 21, 2025 07:25
@munna0908 munna0908 self-assigned this Mar 21, 2025
Copy link
Member

@gmega gmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmega gmega enabled auto-merge March 21, 2025 20:46
@munna0908 munna0908 force-pushed the feat/codexTree-hasher branch from 7a42c8c to 70fd441 Compare March 31, 2025 05:00
@munna0908 munna0908 force-pushed the feat/codexTree-hasher branch from 70fd441 to d4db500 Compare March 31, 2025 05:01
@gmega gmega added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit e9c6d19 Mar 31, 2025
19 checks passed
@gmega gmega deleted the feat/codexTree-hasher branch March 31, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants