Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target master for CI comment-on-PR as v1.3.1 is broken atm. #1932

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

christjt
Copy link
Contributor

No description provided.

@christjt christjt added the do-not-merge Don't merge this PR yet. label Feb 28, 2022
@christjt christjt requested a review from a team as a code owner February 28, 2022 09:38
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👏

@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1932/docs/next/.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch and removed do-not-merge Don't merge this PR yet. labels Feb 28, 2022
@christjt christjt changed the title TEST CI [DO NOT MERGE] fix: target master for CI comment-on-PR as v1.3.1 is broken atm. Feb 28, 2022
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue you linked (unsplash/comment-on-pr#51) proposes hardcoding to 1.3.0 instead. But I suppose this is fine for a while.

@christjt
Copy link
Contributor Author

The issue you linked (unsplash/comment-on-pr#51) proposes hardcoding to 1.3.0 instead. But I suppose this is fine for a while.

If you scroll down 1.3.0 also stopped working it seems

@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1932/docs/next/.

@christjt christjt enabled auto-merge (squash) February 28, 2022 10:07
@christjt christjt merged commit 4ed1e26 into master Feb 28, 2022
@christjt christjt deleted the christjt/ci-test branch February 28, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants