Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Funding Support 🚧 #215

Open
wants to merge 4 commits into
base: v0.11.0
Choose a base branch
from
Open

feat: Add Funding Support 🚧 #215

wants to merge 4 commits into from

Conversation

alex-stone
Copy link
Contributor

What changed? Why?

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Nov 8, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@alex-stone alex-stone changed the base branch from master to v0.11.0 November 13, 2024 18:42
This adds a CryptoAmount types that provides a wrapper for the
underlying CryptoAmount object and can provide helpers for converting
from atomic to whole amounts.
This adds support for generating a quote of a wallet fund operation.

This will be able to be used to execute a fund operation soon.
This adds support for funding wallets using `wallet.fund` or
`address.fund`.

This will be extended to support leveraging a fund quote in a
subsequent commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants