Fix two cases of quadratic behavior (GHSA-66g8-4hjf-77xh) #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we find consecutive blank lines inside a list item, abort early in check_open_blocks by returning NULL. This makes S_process_line skip the calls to open_new_blocks and add_text_to_container. open_new_blocks is a no-op for blank lines. add_text_to_container would add an empty line only for code and HTML blocks which we account for in check_open_blocks. Fixes part of GHSA-66g8-4hjf-77xh. Obsoletes commonmark#475.
Don't use public tree manipulation API. The cycle detection can result in quadratic behavior in deeply nested trees. Manipulate the tree structure manually which is error-prone but also more efficient. Fixes part of GHSA-66g8-4hjf-77xh.
|
This gave me a pretty significant speedup on our regular |
|
The speedup is probably caused by the change to |
|
Yes - saw that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the two issues reported here: GHSA-66g8-4hjf-77xh
Also known as CVE-2023-24824.