Attempt to process cell without semicolon #152

anutosh491 · 2024-06-25T06:06:11Z

Description

Through this PR I am trying to facilitate returning output while the semicolon is being omitted.

Type of change

Please tick all options which are relevant.

Bug fix
New feature
Added/removed dependencies
Required documentation updates

github-actions

clang-tidy made some suggestions

github-actions · 2024-06-25T06:11:13Z

src/xinterpreter.cpp

@@ -153,7 +154,9 @@ __get_cxx_version ()
        auto errorlevel = 0;
        std::string ename;
        std::string evalue;
-        bool compilation_result = false;
+        //bool compilation_result = false;
+        intptr_t output_value;


warning: variable 'output_value' is not initialized [cppcoreguidelines-init-variables]

Suggested change

intptr_t output_value;

intptr_t output_value = 0;

github-actions · 2024-06-25T06:11:13Z

src/xmime_internal.hpp

+ ************************************************************************************/
+
+#ifndef XCPP_MIME_INTERNAL_HPP
+#define XCPP_MIME_INTERNAL_HPP


warning: header guard does not follow preferred style [llvm-header-guard]

Suggested change

#define XCPP_MIME_INTERNAL_HPP

#ifndef GITHUB_WORKSPACE_SRC_XMIME_INTERNAL_HPP

#define GITHUB_WORKSPACE_SRC_XMIME_INTERNAL_HPP

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+            xmime_included = true;
+        }
+
+        intptr_t mimeReprV;


warning: variable 'mimeReprV' is not initialized [cppcoreguidelines-init-variables]

Suggested change

intptr_t mimeReprV;

intptr_t mimeReprV = 0;

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+        bool hadError = false;
+        {
+            std::ostringstream oss;
+            oss << reinterpret_cast<void*>(V);


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

oss << reinterpret_cast<void*>(V); ^

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+        bool hadError = false;
+        {
+            std::ostringstream oss;
+            oss << reinterpret_cast<void*>(V);


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

oss << reinterpret_cast<void*>(V); ^

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+        }
+
+        if (!hadError && mimeReprV != 0) {
+            return *(nl::json*)mimeReprV;


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

return *(nl::json*)mimeReprV; ^

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+        }
+
+        if (!hadError && mimeReprV != 0) {
+            return *(nl::json*)mimeReprV;


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

return *(nl::json*)mimeReprV; ^

github-actions · 2024-06-25T06:11:14Z

src/xmime_internal.hpp

+            return *(nl::json*)mimeReprV;
+        } else {
+            return nl::json::object();
+        }


warning: do not use 'else' after 'return' [llvm-else-after-return]

Suggested change

}

} return nl::json::object();

src/xmime_internal.hpp

github-actions

clang-tidy made some suggestions

src/xinterpreter.cpp

src/xparser.cpp

github-actions · 2024-06-25T06:49:15Z

src/xparser.cpp

+                        if (current != 0)
+                        {
+                            current = 0;
+                            result.push_back("");


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

result.push_back("");

result.emplace_back("");

github-actions · 2024-06-25T06:49:15Z

src/xparser.cpp

+                        if (current != 1)
+                        {
+                            current = 1;
+                            result.push_back("");


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

result.push_back("");

result.emplace_back("");

codecov-commenter · 2024-06-25T07:34:38Z

Codecov Report

Attention: Patch coverage is 55.26316% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4745f72). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage        ?   79.82%           
=======================================
  Files           ?       18           
  Lines           ?      684           
  Branches        ?       70           
=======================================
  Hits            ?      546           
  Misses          ?      138           
  Partials        ?        0

Files	Coverage Δ
src/xparser.cpp	`88.67% <82.35%> (ø)`
src/xinterpreter.cpp	`87.87% <60.86%> (ø)`
src/xmime_internal.hpp	`0.00% <0.00%> (ø)`

Files	Coverage Δ
src/xparser.cpp	`88.67% <82.35%> (ø)`
src/xinterpreter.cpp	`87.87% <60.86%> (ø)`
src/xmime_internal.hpp	`0.00% <0.00%> (ø)`

github-actions

clang-tidy made some suggestions

src/xmime_internal.hpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-06-28T08:44:12Z

src/xmime_internal.hpp

+    inline nl::json mime_repr(intptr_t V)
+    {
+        // Return a JSON mime bundle representing the specified value.
+        void* value_ptr = reinterpret_cast<void*>(V);


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

void* value_ptr = reinterpret_cast<void*>(V); ^

github-actions · 2024-06-28T08:44:12Z

src/xmime_internal.hpp

+    inline nl::json mime_repr(intptr_t V)
+    {
+        // Return a JSON mime bundle representing the specified value.
+        void* value_ptr = reinterpret_cast<void*>(V);


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

void* value_ptr = reinterpret_cast<void*>(V); ^

github-actions · 2024-06-28T08:44:12Z

src/xmime_internal.hpp

+
+            std::string codeString = code.str();
+
+            mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError);


warning: Value stored to 'mimeReprV' is never read [clang-analyzer-deadcode.DeadStores]

mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError); ^

Additional context

src/xmime_internal.hpp:50: Value stored to 'mimeReprV' is never read

mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError); ^

github-actions · 2024-06-28T08:44:13Z

src/xmime_internal.hpp

+            mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError);
+        }
+
+        void* mimeReprV_ptr = reinterpret_cast<void*>(V);


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

void* mimeReprV_ptr = reinterpret_cast<void*>(V); ^

github-actions · 2024-06-28T08:44:13Z

src/xmime_internal.hpp

+            mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError);
+        }
+
+        void* mimeReprV_ptr = reinterpret_cast<void*>(V);


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

void* mimeReprV_ptr = reinterpret_cast<void*>(V); ^

github-actions · 2024-06-28T08:44:13Z

src/xmime_internal.hpp

+
+        if (!hadError && mimeReprV_ptr)
+        {
+            return *(nl::json*) mimeReprV_ptr;


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

return *(nl::json*) mimeReprV_ptr; ^

github-actions · 2024-06-28T08:44:13Z

src/xmime_internal.hpp

+        else
+        {
+            return nl::json::object();
+        }


warning: do not use 'else' after 'return' [llvm-else-after-return]

Suggested change

}

return nl::json::object();

anutosh491 · 2024-06-28T10:43:22Z

src/xmime_internal.hpp

+            std::ostringstream code;
+            code << "using xcpp::mime_bundle_repr;";
+            code << "mime_bundle_repr(";
+            // code << "*(" << getTypeAsString(V);


Commented out.

anutosh491 marked this pull request as draft June 25, 2024 06:06

github-actions bot reviewed Jun 25, 2024

View reviewed changes

src/xmime_internal.hpp Outdated Show resolved Hide resolved

src/xmime_internal.hpp Outdated Show resolved Hide resolved

Attempt to process cell without semicolon

d2d305f

anutosh491 force-pushed the semicolon branch from e50ff35 to d2d305f Compare June 28, 2024 08:38

github-actions bot reviewed Jun 28, 2024

View reviewed changes

anutosh491 commented Jun 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to process cell without semicolon #152

Attempt to process cell without semicolon #152

anutosh491 commented Jun 25, 2024

github-actions bot left a comment

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

github-actions bot left a comment

github-actions bot Jun 25, 2024

github-actions bot Jun 25, 2024

codecov-commenter commented Jun 25, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

github-actions bot Jun 28, 2024

anutosh491 Jun 28, 2024

	#define XCPP_MIME_INTERNAL_HPP
	#ifndef GITHUB_WORKSPACE_SRC_XMIME_INTERNAL_HPP
	#define GITHUB_WORKSPACE_SRC_XMIME_INTERNAL_HPP


		std::string codeString = code.str();

		mimeReprV = Cpp::Evaluate(codeString.c_str(), &hadError);

Attempt to process cell without semicolon #152

Are you sure you want to change the base?

Attempt to process cell without semicolon #152

Conversation

anutosh491 commented Jun 25, 2024

Description

Type of change

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

github-actions bot Jun 25, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jun 25, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot Jun 28, 2024

Choose a reason for hiding this comment

anutosh491 Jun 28, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jun 25, 2024 •

edited

Loading