Extend automatic segmentation CLI to allow continuing annotation #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwai98
commented
Feb 10, 2025
|
I realized that I was missing starting the GUI after returning the viewer, which is now taken care of now. Thank you for the suggestion. This should be GTG now! |
| # We extract the segmentation in "committed_objects" layer, where the user either: | ||
| # a) Performed interactive segmentation / corrections and committed them, OR | ||
| # b) Did not do anything and closed the annotator, i.e. keeps the segmentations as it is. | ||
| instances = viewer.layers["committed_objects"].data |
There was a problem hiding this comment.
Have you tested once that this actually works? I am never sure about the actual state logic of napari.
There was a problem hiding this comment.
Yes, I tried this out, by removing labels, adding segmentations and closing the annotator. It works for all cases!
constantinpape
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #729, to (optionally) support continuing annotation / view automatic segmentations after automatic segmentation CLI process is completed. GTG from my side!