-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pylance #25093
Add pylance #25093
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pylance:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I'm happy to be listed as the maintainer of this recipe 👍 |
@conda-forge/staged-recipes this PR is ready for review. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, or conda-forge/help-ruby. Thanks! |
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Thanks for the comments and reviews @xhochy. Aside from It is a |
I've just noticed several code issues and made two updates too.
The win-64 build issue is still not resolved but it might be now easier to narrow down the cause. |
Luckily for us, bumping the package version up to 0.9.10 solved the win-64 build issue it seems. |
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Bumping the version number to v0.9.12 breaks the linux-64 build. From the CI log, there seems to be an overlinking issue on
|
I'll first check how it goes on v0.9.11 and narrow down the cause of the issue. |
On the surface level, there are no significant changes on |
It is building It might be legitimate to add xz as a dependency. |
Co-authored-by: Uwe L. Korn <[email protected]>
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).