Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to Rust 1.80.0 #937

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

fitzthum
Copy link
Member

@fitzthum fitzthum commented Mar 6, 2025

Pull out the time machine and go back to Rust 1.80.0 so we can match with Kata and Trustee.

I've massaged the lockfile and adjusted our workflows. The workflows are slightly messy, but I've tried to unify things so that each one uses both Rust stable and 1.80.0, except for ARM which only uses 1.80.0. I can't test out all these flows locally, so let's see if it works.

fitzthum added 2 commits March 6, 2025 12:50
To get to this lockfile

cargo update [email protected] --precise 0.14.7
cargo update [email protected] --precise 0.7.4
cargo update [email protected] --precise 0.1.4

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Adjust rust version in our workflows.

Unify things a little bit so that all our workflows are using both
stable and 1.80.0 except for ARM, which only uses 1.80.0.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@fitzthum fitzthum requested a review from a team as a code owner March 6, 2025 19:09
We get a dead code warning when running clippy on the attestation agent
with the bin and ttrpc features. Maybe this is because we are not
building binary main code. Interestingly, this doesn't happen with Rust
1.82.0, so rather than go down the rabbit hole, allow dead code in two
  places for now.

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@fitzthum fitzthum merged commit 1c3bfe8 into confidential-containers:main Mar 7, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants