[KSQL-12881] | Log4j to Log4j2 Migration #10698
Merged
+1,743
−1,401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve comments Fix ksql engine tests Fix test Pass log4j2 config correctly Fix debug level log comment out the broken test temporarily Fix null appender failure Fix tests Fix checkstyle errors Fix more checkstyle errors Fix logger mock related tests Move teardown logic in the test Fix timestamp log file appender Migrate ProcessingLog to log4j2 Fix processing log tests Fix processinglog test Fix processing log message structure Fix processing log impl tests Remove redundant import (cherry picked from commit 6609ed9fa19e573aba2ee3992b9d6b6d6b238f4a)
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Copilot reviewed 255 out of 270 changed files in this pull request and generated no comments.
Files not reviewed (15)
- ksqldb-benchmark/src/main/resources/log4j.properties: Language not supported
- ksqldb-cli/src/assembly/standalone.xml: Language not supported
- ksqldb-api-client/src/test/java/io/confluent/ksql/api/client/ClientTest.java: Evaluated as low risk
- ksqldb-cli/src/main/java/io/confluent/ksql/cli/Cli.java: Evaluated as low risk
- ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/StreamQueryResponseHandler.java: Evaluated as low risk
- ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ClientImpl.java: Evaluated as low risk
- ksqldb-api-client/src/main/java/io/confluent/ksql/api/client/impl/ExecuteQueryResponseHandler.java: Evaluated as low risk
- ksqldb-api-client/src/test/java/io/confluent/ksql/api/client/ClientBasicAuthTest.java: Evaluated as low risk
- ksqldb-cli/src/main/java/io/confluent/ksql/Ksql.java: Evaluated as low risk
- docs/tutorials/event-driven-microservice.md: Evaluated as low risk
- docs/reference/processing-log.md: Evaluated as low risk
- docs/operate-and-deploy/logging.md: Evaluated as low risk
- docs/operate-and-deploy/installation/server-config/index.md: Evaluated as low risk
- config/log4j2-silent.yaml: Evaluated as low risk
- config/log4j2-sql-test.yaml: Evaluated as low risk
Comments suppressed due to low confidence (2)
config/log4j2-file.yaml:9
- Ensure that the custom appender 'io.confluent.ksql.util.TimestampLogFileAppender' is correctly implemented and available in the classpath.
type: io.confluent.ksql.util.TimestampLogFileAppender
config/log4j2-file.yaml:12
- Verify that the 'filePattern' aligns with the intended log rotation strategy and does not cause any unexpected behavior.
filePattern: ${ksql.log.dir}/ksql-cli/cli-%d{yyyy-MM-dd}-%i.log
pbadani
reviewed
Feb 26, 2025
...t/src/test/java/io/confluent/ksql/version/metrics/KsqlVersionCheckerResponseHandlerTest.java
Show resolved
Hide resolved
pbadani
approved these changes
Feb 26, 2025
hrishabhg
approved these changes
Feb 27, 2025
hrishabhg
changed the title
pragatiguptaaa
approved these changes
Mar 3, 2025
|
The semaphore CI tests are failing due to an unrelated issue in kafka streams. I think it should be safe to merge this PR as it was green before doc changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates ksqldb from log4j1 to log4j2 completely. Also ksqldb now uses KafkaAppender provided by log4j2 instead of kafka log4j appender, which was recently removed from kafka.
Testing done
This has been tested locally.
Reviewer checklist