first prototype of randicheck #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leans and functions with case statements
Code and Documentation Coverage ReportDocumentation CoverageClick to view documentation coverage for this PRClick to view documentation coverage for mainCode Coverage SummaryThis PR: Detailed Report Main: Detailed Report Coverage Main & PR Coverage ChangeLines coverage changed by 0.00% and covered lines changed by 0
Functions coverage changed by 0.00% and covered lines changed by 0
Branches... coverage: No comparison data available |
ozgurakgun
reviewed
Nov 7, 2024
| //a constructor for an adt is just a list of types | ||
| #[derive(Clone,Debug)] | ||
| struct Constructor { | ||
| Types: Box<[Type]>, |
There was a problem hiding this comment.
would it not make sense for constructors to remember their name too?
There was a problem hiding this comment.
Assuming you mean name as in L Bool, We can do, I mainly did it like this for simplicity in implementation. so we don't have to deal with optionals in cases like Maybe None where there is no type in the box, and in functions it all just gets referred to generally as constructor (at least in haskell's parser, Rust etc may do this differently), so there would have to be logic to differentiate between these anyway down the line.
|
|
||
| // the full haskell file is a list of data types and functions, where we only support custom types, bools, and functions with case statements | ||
| #[derive(Debug)] | ||
| struct Haskell { |
There was a problem hiding this comment.
I would call this something like Program. our aspiration is that this is not haskell specific.
There was a problem hiding this comment.
I think that's valid in future, but considering that currently this is only targetting haskell, and when adding additional languages this will likely be refactored to a seperate ast file, pushing a change for one word isn't vitally important. I'll make sure to change it for my next commit though.
| .expect("Error loading Haskell language"); | ||
| // query to get the body of a function, which is a case statement, note that there is a recursion issue here at the apply function component | ||
| // as a function may be curried and we can't represent that in the current query language | ||
| let query_function = r#" |
There was a problem hiding this comment.
I am still slightly worried about these queries. how do you know you consumed everything in the input?
There was a problem hiding this comment.
In short the plan is basically to purposely not do that, as we're only querying for the parts of haskell we can deal with right now, In terms of a more production style deployment, we can add or's with wildcards in areas to throw warnings/errors when potentially valuable input is skipped. eg for the function body we can add
_ @giveWarning]
This is generally how I expect to handle recursion using queries as well. My main concern would probably be performance as I'm unsure how efficient queries are compared to manual traversal, but once using multiple languages it should be possible to nicely create language agnostic functions to pull data out of a rust enum or haskell adt just by loading a query cursor with the relevant query.
|
let me know when you think we can merge this @TAswan - there are a few comments from last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't use Oz's code, so doing a seperate PR as Leia seemed to get use out of reading #408 and it'd be nice to keep that seperate. Created using tree sitter queries primarily, and currently supports ADT's with Booleans, and functions using case statements.
converts:
to
Haskell { adt: [DataType { Name: "X", Constructors: [Constructor { Types: [Custom("L"), Bool] }, Constructor { Types: [Custom("R"), Bool, Bool] }] }], fun: [Function { Name: "f", Inputs: [Custom("X")], Output: Bool, Body: [Case("x", Pattern { True_On: [Custom("L"), Custom("True")], gives: True }), Case("x", Pattern { True_On: [Custom("R"), Custom("False"), Custom("_")], gives: True }), Case("x", Pattern { True_On: [Custom("otherwise")], gives: False })] }] }