Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types and state management #38

Merged
merged 20 commits into from
Oct 4, 2024
Merged

Conversation

gskorokhod
Copy link
Contributor

@gskorokhod gskorokhod commented Sep 12, 2024

Goals

  • Switch from interfaces to classes, with proper encapsulation etc
  • Have one State object that can be passed to components and encapsulates looking up objects by UUID and CRUD operations on them
  • Make the new types serializable to JSON and back
  • Ensure consistency between the 3 states that we have in the application:
    • In-memory instances of objects
    • The Svelte global store
    • Serialized data in browser local storage

ToDo

  • New types for Person, Location, Task, Skill, Assignment
  • Some documentation
  • New State object
  • Update the core UI to use new types
  • Update data table components to use new types
  • Clean up code & imports
  • New Generic components

@gskorokhod gskorokhod added kind:documentation Improvements or additions to documentation enhancement New feature or request kind:code Coding tasks area:logic Related to generating Essence and other business logic of the app labels Sep 12, 2024
@gskorokhod gskorokhod self-assigned this Sep 12, 2024
@gskorokhod gskorokhod marked this pull request as draft September 12, 2024 12:06
@gskorokhod gskorokhod marked this pull request as ready for review October 4, 2024 11:57
@gskorokhod gskorokhod merged commit d23aecd into conjure-cp:main Oct 4, 2024
1 check passed
@gskorokhod
Copy link
Contributor Author

this took... way more than expected but I have now updated the core UI to use new types.
Shift & Assignment UI is being redesigned now so I've removed it for now

@gskorokhod gskorokhod mentioned this pull request Oct 4, 2024
@gskorokhod gskorokhod mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logic Related to generating Essence and other business logic of the app enhancement New feature or request kind:code Coding tasks kind:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant