Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inspect should return one array rather than a stream of array #3961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weiyuhang2011
Copy link
Contributor

Description

This PR fixes an issue where nerdctl inspect <container1> <image1> return a stream of array rather than one array.

Steps to reproduce the issue

current

> nerdctl inspect container1 image1
[
    {
       <container1-info>
    }
]
[
    {
       <image1-info>
    }
]

fixed

> nerdctl inspect container1 image1
[
    {
       <container1-info>
    },
    {
       <image1-info>
    }
]

Fix: #3006

@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 3, 2025
@AkihiroSuda
Copy link
Member

Thanks, can we have a test?

@weiyuhang2011
Copy link
Contributor Author

Thanks, can we have a test?

Sure, i will add a test.

@AkihiroSuda AkihiroSuda modified the milestones: v2.0.4, v2.x.x Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nerdctl inspect should not return a stream of json array, but a single array
2 participants