-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add env and user to inspect in dockercompat #4007
base: main
Are you sure you want to change the base?
add env and user to inspect in dockercompat #4007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
CI is failing |
Docker and nerdctl handle create calls with --user differently.
nerdctl on the other hand fails during the create call
|
563925c
to
014161a
Compare
af1725c
to
0f183b1
Compare
@apostasie do you happen to know this error. i am wondering if it is a race condiiton
|
Never seen this. This is buildg territory, right? So, @ktock might have an idea. Let me look more closely at your changeset though. |
Coming from https://github.com/ktock/buildg/blob/main/pkg/buildkit/client.go#L83 - so, definitely buildg. Not sure why or when that would happen, but having looked at your changeset, I do not think this is related and probably is some network fluke. |
0f183b1
to
5d9a892
Compare
Needs rebase |
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
5d9a892
to
bbf2ab7
Compare
Issue:
Docker Compat Inspect doesn't have Env and User parameter for the process
Description:
This PR adds Env and User for the docker compat inspect
Test: