Added HTML sanitization to the blogs card #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautamkrishnar
force-pushed
the
fix/html
branch
from
7637d87 to
5bb303c
Compare
ashley-cui
reviewed
Jan 16, 2024
gautamkrishnar
force-pushed
the
fix/html
branch
from
5bb303c to
7cd38be
Compare
Signed-off-by: GitHub <[email protected]>
gautamkrishnar
force-pushed
the
fix/html
branch
from
7cd38be to
aa1d8d6
Compare
|
/approve |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The WordPress API returns HTML instead of plain text it will cause blog post card to break since react needs them as plain text:
The fix
Added HTML to plain text encoding to prevent this from happening. This will also remove all the unnecessary
<p>tags added by the WP API.