-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests: fix desired network backend checking #25643
base: main
Are you sure you want to change the base?
e2e tests: fix desired network backend checking #25643
Conversation
Setting 'cni' as the network backend then run e2e tests, the following test failure will be hit w/o this patch. # ./test/tools/build/ginkgo -v -focus "Podman info: check desired network backend" test/e2e/ ... Podman Info [It] Podman info: check desired network backend /root/podman/test/e2e/info_test.go:156 [FAILED] Expected <string>: cni to equal <string>: netavark Signed-off-by: Alex Jia <[email protected]>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chuanchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm not familar with the contrib/cirrus/setup_environment.sh, please let me know if it's necessary to add 'CI_DESIRED_NETWORK_BACKEND' into the setup_environment.sh, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we removed that because we don't want to support CNI anymore upstream.
Sure we can make this test work again but overall any new test will only be tested on netavark and I don't want to keep adding these skipIfCNI conditions in upstream code, we should be removing them instead.
If that is the only issue you noticed I am fine merging it but I don't want to patch many tests just to work with cni again.
Got it, please close this PR if we don't want to support CNI again, thanks! |
Setting 'cni' as the network backend then run e2e tests, the following test failure will be hit w/o this patch.
# ./test/tools/build/ginkgo -v -focus "Podman info: check desired network backend" test/e2e/ ...
Podman Info [It] Podman info: check desired network backend /root/podman/test/e2e/info_test.go:156
[FAILED] Expected
<string>: cni
to equal
<string>: netavark
Does this PR introduce a user-facing change?
It's only for testing.