Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar export redesign css fixes #921

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Calendar export redesign css fixes #921

merged 5 commits into from
Feb 18, 2025

Conversation

NIDHI2023
Copy link
Contributor

@NIDHI2023 NIDHI2023 commented Jan 24, 2025 •
edited
Loading

Summary

Small css fixes for #862 , especially mobile view

  • changed dot indicator to actually be red dot, not flash green when TA active
  • removed long fadeIn time for mobile modal view
  • adjust "export to gcal/ical" text font size for mobile view
  • added hover effect to selecting calendar dates to match design prototypes
cal_restyle.mp4

Test Plan

  • red dot only appears for TAs, not students, instead of previously styled indicator when there is a question in the queue
  • could test with more than one question if it still works

Make sure this branch doesn't break anything for other devs with the gitignore additions

Notes

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@NIDHI2023 NIDHI2023 requested a review from a team as a code owner January 24, 2025 02:14
@dti-github-bot
Copy link
Member

dti-github-bot commented Jan 24, 2025 •
edited
Loading

[diff-counting] Significant lines: 19.

EricWeng23
EricWeng23 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@EricWeng23 EricWeng23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NIDHI2023 NIDHI2023 merged commit 91efb20 into master Feb 18, 2025
4 checks passed
@NIDHI2023 NIDHI2023 deleted the nidhi/cal-export-edits branch February 18, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricWeng23 EricWeng23 EricWeng23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NIDHI2023 @dti-github-bot @EricWeng23