Eric / Implement Firebase Function to Monitor Question Status Change #931
+131
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 145. |
NIDHI2023
reviewed
Mar 4, 2025
NIDHI2023
changed the title
|
renaming title so WIP check can pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(In Progress)
This is a follow-up PR to alleviate the overactive listener that was spiking up Firebase cost. This PR addressed this issue by implementing a new firebase function
onQuestionStatusUpdatewhich compares the status of the new and updated question. If status changed to resolved, then we can callremoveQuestionDisplayFeedback. This allows developers to monitor question changes on the server-side rather than the client-side. Specifics is in Richard's past PR: #888The number of
onSnapShotcalls reducesNote: Currently this implementation tries to update the reference to a session document with an array of recentlyResolvedQuestions, but this may not be an optimal and permanent solution.
Test Plan
Screen.Recording.2025-03-02.at.11.10.19.PM.mov
Notes
Breaking Changes
None