Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Trimmed performs badly #28

Open
Yey007 opened this issue Dec 7, 2024 · 3 comments
Open

[core] Trimmed performs badly #28

Yey007 opened this issue Dec 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Yey007
Copy link
Member

Yey007 commented Dec 7, 2024

Trimmed seems to perform way worse than it should. Are we doing something wrong?

@Yey007 Yey007 added the bug Something isn't working label Dec 7, 2024
@ethanuppal ethanuppal changed the title Trimmed performs badly [core] Trimmed performs badly Dec 9, 2024
@Yey007
Copy link
Member Author

Yey007 commented Dec 11, 2024

Jess found the issue! Or at least one of them. We are calculating the centroid for trimmed_b incorrectly. There can be duplicates in the array, skewing the result.

@Yey007
Copy link
Member Author

Yey007 commented Feb 10, 2025

Hmmm... I investigated a bit. I tried to fix this but the performance was way worse. It is possible that our original code is actually correct. If we treat the SVD method as something that simply optimizes the distance cost between pairs of points, fixing the centroid actually breaks the guarantees of the proof, it doesn't restore them. So maybe there is another cause?

@Yey007
Copy link
Member Author

Yey007 commented Feb 10, 2025

But if this is true, that would actually imply that vanilla is wrong. Could this be the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants