Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests/e2e): Multichain e2e test transfer back #381

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mconcat
Copy link
Collaborator

@mconcat mconcat commented Mar 9, 2025

Description

ref: #313

implements:

  • Send back from Cosmos chain B -> ETH -> Cosmos chain A
  • Send back from Cosmos chain B -> Cosmos chain A -> ETH

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (99575b3) to head (9468c14).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         731      731           
=======================================
  Hits          730      730           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mconcat mconcat marked this pull request as ready for review March 10, 2025 13:03
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! 🚀 Great to have a proper test for this!

Plus the nits I added, the name of the tests should also be rename to include the return part. e.g. TestTransferCosmosToEthToCosmosAndBack_Groth16.
Remember to also search for the name and replace in github workflows and any other places it is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants