-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests/e2e): Multichain e2e test transfer back #381
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 14 14
Lines 731 731
=======================================
Hits 730 730
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…olidity-ibc-eureka into e2e-multichain-cosmos-send-back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good! 🚀 Great to have a proper test for this!
Plus the nits I added, the name of the tests should also be rename to include the return part. e.g. TestTransferCosmosToEthToCosmosAndBack_Groth16
.
Remember to also search for the name and replace in github workflows and any other places it is used.
Co-authored-by: Gjermund Garaba <[email protected]>
…olidity-ibc-eureka into e2e-multichain-cosmos-send-back
Description
ref: #313
implements:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.