Disable "housekeeping" tasks for db opened with openAgain() #2225
+42
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a flag `C4DB_NoHousekeeping` that suppresses database "housekeeping" tasks, and makes C4Database::openAgain() set this flag in the database it opens. Housekeeping tasks like expiring documents and SQLite vacuuming only need to be done by one database connection (C4Database), but we do them in all connections. This means CBL wastes some time and also opens twice as many SQLite connections as it needs to (that _backgroundDB that DatabaseImpl opens.) It also enables a nasty deadlock condition when the replicator closes its database(s) -- the close call happens on an actor thread, and ends up calling Housekeeper::stop, which sends an Actor message to the Housekeeper and blocks until it's processed. But if all actor threads are doing this, there are no threads left to actually run the Housekeeper. [CBSE-19205]
pasin
requested changes
Feb 7, 2025
C/include/c4DatabaseTypes.h
Outdated
| kC4DB_ReadOnly = 0x02, ///< Open file read-only | ||
| kC4DB_AutoCompact = 0x04, ///< Enable auto-compaction [UNIMPLEMENTED] | ||
| kC4DB_VersionVectors = 0x08, ///< Upgrade DB to version vectors instead of rev trees | ||
| kC4DB_MmapDisabled = 0x10, ///< Disable MMAP in SQLite. |
There was a problem hiding this comment.
kC4DB_MmapDisabled shouldn't be ported.
|
There is a conflicting file as well. |
snej
requested changes
Feb 7, 2025
LiteCore/Database/DatabaseImpl.cc
Outdated
Comment on lines
153
to
155
| options.diskSyncFull = (_config.flags & kC4DB_DiskSyncFull) != 0; | ||
| options.noHousekeeping = (_config.flags & kC4DB_NoHousekeeping) != 0; | ||
| options.useDocumentKeys = true; |
There was a problem hiding this comment.
Why switch the order of useDocumentKeys and diskSyncFull?
|
"I don't understand why you had to make additional changes due to compiler warnings. Didn't the branch build successfully before this?" -- because in won't pass the compiler with my current Xcode version&setting. |
snej
approved these changes
Feb 7, 2025
pasin
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.