Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inplace.vector] Move reserve+shrink_to_fit from #modifiers to #capacity #7321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Quuxplusone
Copy link
Contributor

In the synopsis [inplace.vector.overview], reserve() and shrink_to_fit() are under size/capacity, but their actual descriptions are in [inplace.vector.modifiers], not [inplace.vector.capacity].

And the English title of [inplace.vector.capacity] doesn't quite match [vector.capacity], either. I think this is editorial and easy to patch.

@jensmaurer
Copy link
Member

@jwakely , what do you think?

@jensmaurer
Copy link
Member

@jwakely , ping.

@AlisdairM
Copy link
Contributor

AlisdairM commented Oct 21, 2024

For reference, this PR triggered me, as I thought the equivalent wording was structured differently in vector. When I checked the PR against our existing text though, I was wrong and I concur that this is the better way.

@Quuxplusone
Copy link
Contributor Author

Data point: I, also, think it's weird that resize isn't under "modifiers," and would be totally fine if someone went and fixed all the other containers to put resize, reserve, and shrink_to_fit under "modifiers" instead. :) But consistent one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants