[4.7] Add require coupon code lightswitch to discounts #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds extra protection against discounts being accidentally applied when removing all coupon codes
…tswitch-to-discounts
lukeholder
changed the title
|
@AugustMiller would love to get your input on the wording of "Require Coupon Code". Toyed with the idea of "Requires" but then felt like it should be "Requires a Coupon Code" which seems lengthier. The idea behind the PR being this is now an extra fail safe that you explicitly say whether the discount needs a coupon code to apply rather than simply an empty coupons table. Which causes issue if someone was to accidentally delete all the codes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
#3132