Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PDF URL issue #1150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix PDF URL issue #1150

wants to merge 1 commit into from

Conversation

radhika587
Copy link
Collaborator

  • Removed repeated characters from hashids.php file

@radhika587 radhika587 linked an issue Mar 9, 2023 that may be closed by this pull request
PDF URLs #1142
Open
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

Uffizzi Preview Environment deployment-18561

☁️ https://app.uffizzi.com//github.com/crater-invoice/crater/pull/1150

📄 View Application Logs etc.

What is Uffizzi? Learn more

pepa65
pepa65 reviewed Mar 11, 2023
View reviewed changes
Copy link

@pepa65 pepa65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix I think, there are no duplicate characters, even if you convert the whole alphabet to uppercase (or lowercase).

gdarko added a commit to InvoiceShelf/InvoiceShelf that referenced this pull request Jan 29, 2024
@gdarko
Fix duplicate character in generated hashes
fedfea9 
Pull: crater-invoice/crater#1150 / Issue: crater-invoice/crater#1142
@gdarko gdarko mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepa65 pepa65 pepa65 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF URLs
2 participants
@radhika587 @pepa65