Skip to content

Commit

Permalink
Build(deps-dev): Bump the bundler-dev group with 4 updates (#3754)
Browse files Browse the repository at this point in the history
Bumps the bundler-dev group with 4 updates:
[rubocop-capybara](https://github.com/rubocop/rubocop-capybara),
[rubocop-performance](https://github.com/rubocop/rubocop-performance),
[rubocop-rspec](https://github.com/rubocop/rubocop-rspec) and
[sorbet-runtime](https://github.com/sorbet/sorbet).

Updates `rubocop-capybara` from 2.19.0 to 2.20.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-capybara/releases">rubocop-capybara's
releases</a>.</em></p>
<blockquote>
<h2>RuboCop Capybara v2.20.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add new <code>Capybara/RedundantWithinFind</code> cop. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Change to default <code>EnforcedStyle: link_or_button</code> for
<code>Capybara/ClickLinkOrButtonStyle</code> cop. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Change to default <code>EnforcedStyle: have_no</code> for
<code>Capybara/NegationMatcher</code> cop. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Fix a false negative for <code>RSpec/HaveSelector</code> when first
argument is dstr node. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Fix an invalid attributes parse when name with multiple
<code>[]</code> for <code>Capybara/SpecificFinders</code> and
<code>Capybara/SpecificActions</code> and
<code>Capybara/SpecificMatcher</code>. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Fix a false positive for <code>Capybara/SpecificMatcher</code> when
<code>text:</code> or <code>exact_text:</code> with regexp. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/rubocop/rubocop-capybara/compare/v2.19.0...v2.20.0">https://github.com/rubocop/rubocop-capybara/compare/v2.19.0...v2.20.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md">rubocop-capybara's
changelog</a>.</em></p>
<blockquote>
<h2>2.20.0 (2024-01-03)</h2>
<ul>
<li>Change to default <code>EnforcedStyle: link_or_button</code> for
<code>Capybara/ClickLinkOrButtonStyle</code> cop. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Fix a false negative for <code>RSpec/HaveSelector</code> when first
argument is dstr node. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Add new <code>Capybara/RedundantWithinFind</code> cop. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Fix an invalid attributes parse when name with multiple
<code>[]</code> for <code>Capybara/SpecificFinders</code> and
<code>Capybara/SpecificActions</code> and
<code>Capybara/SpecificMatcher</code>. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Change to default <code>EnforcedStyle: have_no</code> for
<code>Capybara/NegationMatcher</code> cop. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Fix a false positive for <code>Capybara/SpecificMatcher</code> when
<code>text:</code> or <code>exact_text:</code> with regexp. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/ae32988c4e71ff11fe2d465ef129a0bb3aa1e9f9"><code>ae32988</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-capybara/issues/88">#88</a>
from rubocop/bump-version</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/2e837212ca1452da785547a47dd7062f6b58c7df"><code>2e83721</code></a>
Bump version v2.20.0</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/1e11df9b1739eaba49c945d4a1b8ec3e57c3558c"><code>1e11df9</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-capybara/issues/87">#87</a>
from rubocop/fix82</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/5f7fffe792ba46a4175d1570790d9029d22403d8"><code>5f7fffe</code></a>
Fix a false positive for <code>Capybara/SpecificMatcher</code> when
<code>text:</code> or `exact_te...</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/4c0a43b19c3084cc164cd10d81fbe8ab34b8cfdd"><code>4c0a43b</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-capybara/issues/60">#60</a>
from rubocop/fix/57</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/92bf3dd4236280eaf93e64966237659ce18e56d0"><code>92bf3dd</code></a>
Change to default <code>EnforcedStyle: have_no</code> for
<code>Capybara/NegationMatcher</code> cop</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/f265f29679c74699d0d1c08083ae27e9792b1c4c"><code>f265f29</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-capybara/issues/86">#86</a>
from rubocop/3.3-in-ci</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/372ed36be8d55bdfa6feb0db13b4a65619bcecf1"><code>372ed36</code></a>
Add Ruby 3.3 to CI matrix</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/816fa4bb6a5c162c10b833bf440e51c402c0b626"><code>816fa4b</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-capybara/issues/77">#77</a>
from rubocop/feature/75</li>
<li><a
href="https://github.com/rubocop/rubocop-capybara/commit/fa74ea12507287897b5ca9680fb4a931711e3e5e"><code>fa74ea1</code></a>
Merge branch 'main' into feature/75</li>
<li>Additional commits viewable in <a
href="https://github.com/rubocop/rubocop-capybara/compare/v2.19.0...v2.20.0">compare
view</a></li>
</ul>
</details>
<br />

Updates `rubocop-performance` from 1.20.1 to 1.20.2
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md">rubocop-performance's
changelog</a>.</em></p>
<blockquote>
<h2>1.20.2 (2024-01-08)</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/425">#425</a>:
Fix a false positive for
<code>Performance/StringIdentifierArgument</code> when using string
interpolation with methods that don't support symbols with
<code>::</code> inside them. ([<a
href="https://github.com/earlopain"><code>@​earlopain</code></a>][])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/ad65d4e77975ed6d55dbeb62118c9b0c79bdbad7"><code>ad65d4e</code></a>
Cut 1.20.2</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/2e13b10e2c586ecd8b5091889901d5a501e77a6c"><code>2e13b10</code></a>
Update Changelog</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/b69aabbe591bfbbb800ce4951851fdc5de9dc638"><code>b69aabb</code></a>
Use RuboCop RSpec 2.26</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/43e8786124827ce8f3339553a75927360ba87f4f"><code>43e8786</code></a>
Raise an exception if automation task <code>system</code> fails</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/cbc1dd5d6152dfcec5be3704bfaf5c30cbc68a08"><code>cbc1dd5</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/430">#430</a>
from Earlopain/fix-425</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/749d0721e55502202e98b611451cf677a9bc74ce"><code>749d072</code></a>
[Fix <a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/425">#425</a>]
Fix a false positive
for<code>Performance/StringIdentifierArgument</code></li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/6e7c4cfb8c0e461467f1471c4a84b7ea42d66b75"><code>6e7c4cf</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/429">#429</a>
from koic/ci_against_ruby_3_3</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/446c96eda69d1b6032e5354b5e3d7fe566632e7a"><code>446c96e</code></a>
CI against Ruby 3.3</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/96878e4a9dca0417ea9933c69cb8173a0d4dd159"><code>96878e4</code></a>
Switch back docs version to master</li>
<li>See full diff in <a
href="https://github.com/rubocop/rubocop-performance/compare/v1.20.1...v1.20.2">compare
view</a></li>
</ul>
</details>
<br />

Updates `rubocop-rspec` from 2.25.0 to 2.26.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-rspec/releases">rubocop-rspec's
releases</a>.</em></p>
<blockquote>
<h2>RuboCop RSpec v2.26.1</h2>
<ul>
<li>Fix an error for <code>RSpec/SharedExamples</code> when using
examples without argument. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
</ul>
<h2>RuboCop RSpec v2.26.0</h2>
<ul>
<li>Add new <code>RSpec/RedundantPredicateMatcher</code> cop. (<a
href="https://github.com/ydah"><code>@​ydah</code></a>)</li>
<li>Add new <code>RSpec/RemoveConst</code> cop. (<a
href="https://github.com/swelther"><code>@​swelther</code></a>)</li>
<li>Add support for correcting &quot;it will&quot; (future tense) for
<code>RSpec/ExampleWording</code>. (<a
href="https://github.com/jdufresne"><code>@​jdufresne</code></a>)</li>
<li>Add support for <code>symbol</code> style for
<code>RSpec/SharedExamples</code>. (<a
href="https://github.com/jessieay"><code>@​jessieay</code></a>)</li>
<li>Ensure <code>PendingWithoutReason</code> can detect violations
inside shared groups. (<a
href="https://github.com/robinaugh"><code>@​robinaugh</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md">rubocop-rspec's
changelog</a>.</em></p>
<blockquote>
<h2>2.26.1 (2024-01-05)</h2>
<ul>
<li>Fix an error for <code>RSpec/SharedExamples</code> when using
examples without argument. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
</ul>
<h2>2.26.0 (2024-01-04)</h2>
<ul>
<li>Add new <code>RSpec/RedundantPredicateMatcher</code> cop. ([<a
href="https://github.com/ydah"><code>@​ydah</code></a>])</li>
<li>Add new <code>RSpec/RemoveConst</code> cop. ([<a
href="https://github.com/swelther"><code>@​swelther</code></a>])</li>
<li>Add support for correcting &quot;it will&quot; (future tense) for
<code>RSpec/ExampleWording</code>. ([<a
href="https://github.com/jdufresne"><code>@​jdufresne</code></a>])</li>
<li>Add support for <code>symbol</code> style for
<code>RSpec/SharedExamples</code>. ([<a
href="https://github.com/jessieay"><code>@​jessieay</code></a>])</li>
<li>Ensure <code>PendingWithoutReason</code> can detect violations
inside shared groups. ([<a
href="https://github.com/robinaugh"><code>@​robinaugh</code></a>])</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/b303710c2d26f32fa6f36d379503fbf08d4132d1"><code>b303710</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-rspec/issues/1771">#1771</a>
from rubocop/release</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/fce059bbf1591c5b9c1c0b8d0db59f0f627f88c8"><code>fce059b</code></a>
Bump version to v2.26.1</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/6d9eec251645c75f195340da57887fe909a846f2"><code>6d9eec2</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-rspec/issues/1769">#1769</a>
from rubocop/followup</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/3b6eeb60cb75f9148ae6955bdcd5e00413614870"><code>3b6eeb6</code></a>
Follow up <a
href="https://redirect.github.com/rubocop/rubocop-rspec/pull/1768#discussion_r1442">rubocop/rubocop-rspec#1768</a>...</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/6e19ee6531654c5435b44589fda9f8e5764c5c54"><code>6e19ee6</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-rspec/issues/1768">#1768</a>
from rubocop/fix1765</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/6081d6507049b6f067f63f294b685151045cec22"><code>6081d65</code></a>
Fix an error for <code>RSpec/SharedExamples</code> when using examples
without argument</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/b7d192a75f3f99cfeb42d1ffc17c76073c3f6864"><code>b7d192a</code></a>
Switch docs version back</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/97407ea455a49c2e74a7ec8dc40f18b0910ce457"><code>97407ea</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-rspec/issues/1763">#1763</a>
from rubocop/release</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/d1f0725b187c721d4adb19415c8aef14472a6c37"><code>d1f0725</code></a>
Bump version to v2.26.0</li>
<li><a
href="https://github.com/rubocop/rubocop-rspec/commit/2825622d13dba09eca41940da2f4fb0d10f14618"><code>2825622</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-rspec/issues/1746">#1746</a>
from jessieay/master</li>
<li>Additional commits viewable in <a
href="https://github.com/rubocop/rubocop-rspec/compare/v2.25.0...v2.26.1">compare
view</a></li>
</ul>
</details>
<br />

Updates `sorbet-runtime` from 0.5.11164 to 0.5.11178
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/sorbet/sorbet/releases">sorbet-runtime's
releases</a>.</em></p>
<blockquote>
<h2>sorbet 0.5.11177.20240105103412-15aa5874a</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11177', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11177'
</code></pre>
<h2>sorbet 0.5.11176.20240104122727-0f8f23c4d</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11176', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11176'
</code></pre>
<h2>sorbet 0.5.11175.20240103143002-ddd14d633</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11175', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11175'
</code></pre>
<h2>sorbet 0.5.11174.20240103134548-3b18f876d</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11174', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11174'
</code></pre>
<h2>sorbet 0.5.11173.20240103104327-ee31a06a5</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11173', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11173'
</code></pre>
<h2>sorbet 0.5.11172.20240103103218-2016d442b</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11172', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11172'
</code></pre>
<h2>sorbet 0.5.11171.20240103103742-4c82b6518</h2>
<p>To use Sorbet add this line to your Gemfile:</p>
<pre><code>gem 'sorbet', '0.5.11171', :group =&gt; :development
gem 'sorbet-runtime', '0.5.11171'
</code></pre>
<h2>sorbet 0.5.11170.20240102151700-8bd792751</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a
href="https://github.com/sorbet/sorbet/commits">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin ! <[email protected]>
  • Loading branch information
dependabot[bot] and just1602 authored Jan 8, 2024
1 parent 775a95e commit 0e31fa1
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 28 deletions.
16 changes: 8 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ GEM
rexml (~> 3.2)
pandoc-ruby (2.1.10)
parallel (1.24.0)
parser (3.2.2.4)
parser (3.3.0.2)
ast (~> 2.4.1)
racc
pg (1.5.4)
Expand Down Expand Up @@ -338,7 +338,7 @@ GEM
redis-store (1.10.0)
redis (>= 4, < 6)
referral (0.0.5)
regexp_parser (2.8.3)
regexp_parser (2.9.0)
request_store (1.5.1)
rack (>= 1.4)
reverse_markdown (2.1.1)
Expand Down Expand Up @@ -378,19 +378,19 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.19.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.24.0)
rubocop (~> 1.33)
rubocop-performance (1.20.1)
rubocop-factory_bot (2.25.1)
rubocop (~> 1.41)
rubocop-performance (1.20.2)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-rails (2.23.1)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 1.33.0, < 2.0)
rubocop-ast (>= 1.30.0, < 2.0)
rubocop-rspec (2.25.0)
rubocop-rspec (2.26.1)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
Expand Down Expand Up @@ -435,7 +435,7 @@ GEM
sitemap_generator (6.3.0)
builder (~> 3.0)
smart_properties (1.17.0)
sorbet-runtime (0.5.11164)
sorbet-runtime (0.5.11178)
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
Expand Down
2 changes: 1 addition & 1 deletion spec/services/tag_assigner_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
expect(described_class.parse_glob(glob).tags.map(&:name)).to eq %w[foo bar baz]
end

it 'will drop blank tags' do
it 'drops blank tags' do
glob = 'foo,, bar'
expect(described_class.parse_glob(glob).tags.map(&:name)).to eq %w[foo bar]
end
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ def login_user _user
fill_in 'password', with: 'c' * 31
end

click_button 'Sign In'
click_link_or_button 'Sign In'
expect(page).to have_content 'Logged in!'
end
8 changes: 4 additions & 4 deletions spec/system/admin_live_blog_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
login_user(admin)
visit '/admin/articles'

click_link article.title
click_link 'NEW Nested Article'
click_link_or_button article.title
click_link_or_button 'NEW Nested Article'

fill_in 'article_title', with: blog_update_title
within('#datetime') { click_button 'Publish NOW!' }
within('#datetime') { click_link_or_button 'Publish NOW!' }

expect(page).to have_content "Part of the #{article.name} Collection"

click_link article.title, match: :first
click_link_or_button article.title, match: :first
within('#collection') do
expect(page).to have_content blog_update_title
end
Expand Down
4 changes: 2 additions & 2 deletions spec/system/admin_sign_ins_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
fill_in 'username', with: 'user1'
fill_in 'password', with: 'c' * 31
end
click_button 'Sign In'
click_link_or_button 'Sign In'

expect(page).to have_content 'Logged in!'
expect(page).to have_current_path(admin_dashboard_path)
Expand All @@ -26,7 +26,7 @@
fill_in 'username', with: 'user2'
fill_in 'password', with: 'Ba' * 30
end
click_button 'Sign In'
click_link_or_button 'Sign In'

# TODO: is it weird that we don’t go back to /signin and there is no error message?
expect(page).to have_current_path(sessions_path)
Expand Down
12 changes: 6 additions & 6 deletions spec/system/article_datetime_settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
login_user(admin)
visit '/admin/articles'

click_link 'NEW'
click_link_or_button 'NEW'

within '#publication_datetime' do
execute_script("document.getElementById('publication_date').value = '2018-12-24';")
Expand All @@ -40,7 +40,7 @@
login_user(admin)
visit '/admin/articles'

click_link 'EDIT'
click_link_or_button 'EDIT'
within '#publication_datetime' do
# make sure pre-fills are right
expect(find_field('published_at_date').value).to eq '2018-12-24'
Expand All @@ -65,7 +65,7 @@
login_user(admin)
visit '/admin/articles'

click_link 'NEW'
click_link_or_button 'NEW'

within('#publication-status') { find('label[for=publication_status_draft]').click }

Expand All @@ -81,9 +81,9 @@
login_user(admin)
visit '/admin/articles'

click_link 'NEW'
click_link_or_button 'NEW'

within('#datetime') { click_button 'Publish NOW!' }
within('#datetime') { click_link_or_button 'Publish NOW!' }

expect(page).to have_content 'Article was successfully created'
article = Article.last
Expand All @@ -99,7 +99,7 @@
login_user(admin)
visit '/admin/articles'

click_link 'NEW'
click_link_or_button 'NEW'

within('#publication-status') { find('label[for=publication_status_published]').click }
find_button('Save', match: :first).click
Expand Down
4 changes: 2 additions & 2 deletions spec/system/language_landing_page_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
link_triplets.each do |triple|
english = triple.last
triple.each do |link_text|
click_link link_text, match: :first
click_link_or_button link_text, match: :first
expect(page).to have_content english
visit '/languages'
end
Expand All @@ -88,7 +88,7 @@

visit '/languages'

within('#locales') { expect(page).not_to have_content 'Italian' }
within('#locales') { expect(page).to have_no_content 'Italian' }
end

it 'redirects to the language index page if a language is not found' do
Expand Down
8 changes: 4 additions & 4 deletions spec/system/tools_index_pages_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
visit '/zines'

expect(page).to have_content 'published'
expect(page).not_to have_content 'draft'
expect(page).not_to have_content 'not live'
expect(page).to have_no_content 'draft'
expect(page).to have_no_content 'not live'
end

it 'Renders published posters calling /posters' do
Expand Down Expand Up @@ -114,7 +114,7 @@
visit '/videos'

expect(page).to have_content 'published'
expect(page).not_to have_content 'not live'
expect(page).not_to have_content 'draft'
expect(page).to have_no_content 'not live'
expect(page).to have_no_content 'draft'
end
end

0 comments on commit 0e31fa1

Please sign in to comment.