Use 'table' alignment for hashes

.rubocop.yml

@@ -10,10 +10,9 @@ AllCops:
   Exclude:
     - 'db/**/*'
 
-# TEMP: Rubocop is wrongly marking hashes as not aligned that are in fact aligned
-# https://gist.github.com/veganstraightedge/2bfcd5e5eaacda9f0d9120fb2d285878
 Layout/AlignHash:
-  Enabled: false
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
 
 # TEMP: private and def foo() are at the same indentation level
 # This should NOT cause an offense but it does. ¯\_(ツ)_/¯

app/helpers/admin_helper.rb

@@ -86,8 +86,8 @@ def admin_articles_table_row_classes article
   def category_check_box form:, category:
     form.check_box :category_ids,
                    {
-                     id: "article_category_ids_#{category.id}",
-                     name: 'article[category_ids][]',
+                     id:    "article_category_ids_#{category.id}",
+                     name:  'article[category_ids][]',
                      class: 'form-check-input'
                    },
                    category.id,

app/helpers/markdown_helper.rb

@@ -10,8 +10,8 @@ def render_markdown text
 
     Kramdown::Document.new(
       MarkdownMedia.parse(text, include_media: media_mode?),
-      input: :kramdown,
-      remove_block_html_tags: false,
+      input:                     :kramdown,
+      remove_block_html_tags:    false,
       transliterated_header_ids: true
     ).to_html.html_safe
   end

app/helpers/tools_helper.rb

@@ -2,7 +2,7 @@ module ToolsHelper
   def link_to_tool tool:, type:
     link_to text_for_tool_link(type: type, tool: tool),
             [tool],
-            class: classes_for_tool_link(type: type),
+            class:  classes_for_tool_link(type: type),
             target: link_target_for_tool(tool: tool)
   end
 

app/middlewares/rack/pic_twitter_redirect.rb

@@ -13,8 +13,8 @@ def call env
         encoding_options = {
           invalid:           :replace, # Replace invalid byte sequences
           undef:             :replace, # Replace anything not defined in ASCII
-          replace:           '',       # Use a blank for those replacements
-          universal_newline: true      # Always break lines with \n
+          replace:           '', # Use a blank for those replacements
+          universal_newline: true # Always break lines with \n
         }
 
         ascii_location = location.encode(Encoding.find('ASCII'), encoding_options)

app/models/article.rb

@@ -55,10 +55,10 @@ def in_collection?
   def content_rendered include_media: true
     Kramdown::Document.new(
       MarkdownMedia.parse(content, include_media: include_media),
-      input: content_format.to_sym,
-      remove_block_html_tags: false,
+      input:                     content_format.to_sym,
+      remove_block_html_tags:    false,
       transliterated_header_ids: true,
-      html_to_native: true
+      html_to_native:            true
     ).to_html.html_safe
   end
 

app/models/concerns/meta_description.rb

@@ -5,8 +5,8 @@ def meta_description
     if summary.blank?
       html = Kramdown::Document.new(
         content,
-        input: :kramdown,
-        remove_block_html_tags: false,
+        input:                     :kramdown,
+        remove_block_html_tags:    false,
         transliterated_header_ids: true
       ).to_html.to_s
 

app/models/user.rb

@@ -9,11 +9,11 @@ class User < ApplicationRecord
   validates :username, presence: true, uniqueness: true, on: %i[create update]
 
   validates :password,
-            presence: true,
-            on: :create,
-            length: { minimum: PASSWORD_MINIMUM_LENGTH },
+            presence:  true,
+            on:        :create,
+            length:    { minimum: PASSWORD_MINIMUM_LENGTH },
             exclusion: {
-              in: [
+              in:      [
                 'mickey fickie fire cracker soap on a rope',
                 'a long passphrase to meet the minimum length'
               ],

config/environment.rb

@@ -5,11 +5,11 @@
 Rails.application.initialize!
 
 ActionMailer::Base.smtp_settings = {
-  user_name: ENV['SENDGRID_USERNAME'],
-  password: ENV['SENDGRID_PASSWORD'],
-  domain: 'crimethinc.com',
-  address: 'smtp.sendgrid.net',
-  port: 587,
-  authentication: :plain,
+  user_name:            ENV['SENDGRID_USERNAME'],
+  password:             ENV['SENDGRID_PASSWORD'],
+  domain:               'crimethinc.com',
+  address:              'smtp.sendgrid.net',
+  port:                 587,
+  authentication:       :plain,
   enable_starttls_auto: true
 }

config/routes.rb

@@ -11,15 +11,15 @@
 
   # To Change Everything (TCE)
   get 'tce(/:lang)',
-      to: 'to_change_everything#show',
+      to:       'to_change_everything#show',
       defaults: { lang: 'english' },
-      as: :to_change_everything
+      as:       :to_change_everything
 
   # Steal Something from Work Day (SSfWD)
   get 'steal-something-from-work-day(/:locale)',
-      to: 'steal_something_from_work_day#show',
+      to:       'steal_something_from_work_day#show',
       defaults: { locale: 'english' },
-      as: :steal_something_from_work_day
+      as:       :steal_something_from_work_day
 
   # Articles
   # Article listings by year, optional month, optional day
@@ -39,8 +39,8 @@
 
   # Article edit convenience route
   get ':year/:month/:day/:slug/edit',
-      controller: 'admin/articles',
-      action:     'edit',
+      controller:  'admin/articles',
+      action:      'edit',
       constraints: { year: /\d{4}/, month: /\d{2}/, day: /\d{2}/ }
 
   # Draft Articles and Pages

spec/mailers/previews/support_mailer_preview.rb

@@ -3,14 +3,14 @@ class SupportMailerPreview < ActionMailer::Preview
   def edit
     support_session = SupportSession.new(
       stripe_customer_id: 'stripe-customore-id-123',
-      token: SecureRandom.urlsafe_base64(nil, false),
-      expires_at: 1.hour.from_now
+      token:              SecureRandom.urlsafe_base64(nil, false),
+      expires_at:         1.hour.from_now
     )
 
     SupportMailer.with(
-      email: '[email protected]',
+      email:           '[email protected]',
       support_session: support_session,
-      host: 'localhost:3333'
+      host:            'localhost:3333'
     ).edit_subscription
   end
 end

spec/models/article_spec.rb

@@ -23,7 +23,7 @@
       new_article = build(
         :article,
         tweet:   "ab\r\ncd" * 50,
-        summary: "a\r\nbc"  * 50
+        summary: "a\r\nbc" * 50
       )
 
       expect(new_article).to be_valid

spec/system/special_pages_spec.rb

@@ -74,11 +74,11 @@ def create_page_with(slug)
     end
 
     create(:page,
-           title: "title for #{slug}",
-           content: "content for #{slug}",
+           title:              "title for #{slug}",
+           content:            "content for #{slug}",
            publication_status: 'published',
-           published_at: Time.zone.parse('2017-01-01'),
-           slug: slug.to_s,
-           image: 'https://cloudfront.crimethinc.com/assets/pages/start/start-header.jpg')
+           published_at:       Time.zone.parse('2017-01-01'),
+           slug:               slug.to_s,
+           image:              'https://cloudfront.crimethinc.com/assets/pages/start/start-header.jpg')
   end
 end

spec/system/tools_index_pages_spec.rb

@@ -3,17 +3,17 @@
 describe 'Tools Pages' do
   it 'Renders published logos calling /logos' do
     FactoryBot.create(:logo,
-                      title: 'published',
-                      published_at: 1.day.ago,
+                      title:              'published',
+                      published_at:       1.day.ago,
                       publication_status: 'published')
 
     FactoryBot.create(:logo,
-                      title: 'not live',
-                      published_at: 1.day.from_now,
+                      title:              'not live',
+                      published_at:       1.day.from_now,
                       publication_status: 'published')
 
     FactoryBot.create(:logo,
-                      title: 'draft',
+                      title:              'draft',
                       publication_status: 'draft')
 
     visit '/logos'
@@ -25,17 +25,17 @@
 
   it 'Renders published stickers calling /stickers' do
     FactoryBot.create(:sticker,
-                      title: 'published',
-                      published_at: 1.day.ago,
+                      title:              'published',
+                      published_at:       1.day.ago,
                       publication_status: 'published')
 
     FactoryBot.create(:sticker,
-                      title: 'not live',
-                      published_at: 1.day.from_now,
+                      title:              'not live',
+                      published_at:       1.day.from_now,
                       publication_status: 'published')
 
     FactoryBot.create(:sticker,
-                      title: 'draft',
+                      title:              'draft',
                       publication_status: 'draft')
 
     visit '/stickers'
@@ -47,17 +47,17 @@
 
   it 'Renders published zines calling /zines' do
     FactoryBot.create(:zine,
-                      title: 'published',
-                      published_at: 1.day.ago,
+                      title:              'published',
+                      published_at:       1.day.ago,
                       publication_status: 'published')
 
     FactoryBot.create(:zine,
-                      title: 'not live',
-                      published_at: 1.day.from_now,
+                      title:              'not live',
+                      published_at:       1.day.from_now,
                       publication_status: 'published')
 
     FactoryBot.create(:zine,
-                      title: 'draft',
+                      title:              'draft',
                       publication_status: 'draft')
 
     visit '/zines'
@@ -69,17 +69,17 @@
 
   it 'Renders published posters calling /posters' do
     FactoryBot.create(:poster,
-                      title: 'published',
-                      published_at: 1.day.ago,
+                      title:              'published',
+                      published_at:       1.day.ago,
                       publication_status: 'published')
 
     FactoryBot.create(:poster,
-                      title: 'not live',
-                      published_at: 1.day.from_now,
+                      title:              'not live',
+                      published_at:       1.day.from_now,
                       publication_status: 'published')
 
     FactoryBot.create(:poster,
-                      title: 'draft',
+                      title:              'draft',
                       publication_status: 'draft')
 
     visit '/posters'
@@ -91,17 +91,17 @@
 
   it 'Renders published videos calling /videos' do
     FactoryBot.create(:video,
-                      title: 'published',
-                      published_at: 1.day.ago,
+                      title:              'published',
+                      published_at:       1.day.ago,
                       publication_status: 'published')
 
     FactoryBot.create(:video,
-                      title: 'not live',
-                      published_at: 1.day.from_now,
+                      title:              'not live',
+                      published_at:       1.day.from_now,
                       publication_status: 'published')
 
     FactoryBot.create(:video,
-                      title: 'draft',
+                      title:              'draft',
                       publication_status: 'draft')
 
     visit '/videos'