Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type will change to iterator #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add return type will change to iterator #134

wants to merge 1 commit into from

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Aug 19, 2024

#[\ReturnTypeWillChange] is required to avoid php notices on recent php versions

@lekoala
Add return type will change to iterator
b7dd236 
#[\ReturnTypeWillChange] is required to avoid php notices on recent php versions
@lekoala
Copy link
Contributor Author

lekoala commented Jan 5, 2025

@Nevett coud you have a look at this?

@lekoala
Copy link
Contributor Author

lekoala commented Jan 20, 2025

or @Haziba ? :-)

Haziba
Haziba approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Haziba Haziba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, an absolutely solid addition. Great work, and thank you for contributing! @Nevett, take it away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haziba Haziba Haziba approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lekoala @Haziba