Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump QEMU to 9.2.0 and update to Release 0.12.0 #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AntonOks
Copy link

@AntonOks AntonOks commented Jan 3, 2025

Please remember to add a git tag v0.12.0 and push it to GitHub!

Feel free to review the created v0.12.0 release and it's assets in my repo: https://github.com/AntonOks/qemu-resources/releases

THANKS!

Please remember to add a git tag v0.12.0 and push it to GitHub!
@@ -411,7 +416,7 @@ def ldflags
"#{brew_prefix}/opt/glib/lib/libgio-2.0.a",
"#{brew_prefix}/opt/glib/lib/libgmodule-2.0.a",
"#{brew_prefix}/opt/glib/lib/libgobject-2.0.a",
"#{brew_prefix}/opt/pixman/lib/libpixman-1.a",
"#{brew_prefix}/opt/pixman/lib/libpixman-1.dylib",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to statically link against all non-system dependencies. On several occasions GitHub as removed dependencies without any notification.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this was the only library:

  1. I found by recursive dir listing AND
  2. which successfully compiled finally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following. The static library doesn't exist anymore or it doesn't compile with it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there was no libpixman-1.a or similar lib anymore. The only one was the dylib one...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I need to give this some thought. Perhaps we need to build that library ourselves.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think building the library ourselves is the quickest solution.

@jacob-carlborg
Copy link
Contributor

Have you tested this change with any of the images or the action?

@AntonOks
Copy link
Author

AntonOks commented Jan 3, 2025

Have you tested this change with any of the images or the action?

No. And I doubt I'll have time to dig deeper into all this in the next weeks :|

@AntonOks
Copy link
Author

@jacob-carlborg

Have you made up your mind how to proceed? What's next now?

@jacob-carlborg
Copy link
Contributor

jacob-carlborg commented Feb 15, 2025

@AntonOks if the package manager doesn't provide a static library we need to compile it ourselves to produce a static library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants