fix: CRXJS does not work with content script in "MAIN" world, link is… #851

mLiGuangYuan · 2024-01-02T10:49:19Z

…sues: #695

changeset-bot · 2024-01-02T10:49:22Z

⚠️ No Changeset found

Latest commit: 5744c1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-01-02T10:49:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
vite-plugin-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 14, 2024 7:11pm

MindsightsAI · 2024-01-05T14:59:19Z

Is it fully solve #695 ?

mLiGuangYuan · 2024-01-05T15:03:06Z

Is it fully solve #695 ?

yep, but this is just an idea to solve the problem, just for reference, this PR has been linked to #695, I feel that the PR I submitted is just a temporary solution, I hope you help to improve it!

mLiGuangYuan · 2024-01-05T15:07:07Z

I realize that this form of code I'm submitting is up for consideration, and I look forward to your better solutions!

MindsightsAI · 2024-01-05T15:37:18Z

@mLiGuangYuan is it work with hot reload? Do you have workable solution with additional content script in MAIN world that work with hot reload?

mLiGuangYuan · 2024-01-05T15:44:28Z

@mLiGuangYuan is it work with hot reload? Do you have workable solution with additional content script in MAIN world that work with hot reload?

Yes, It's does support hot reloading, just remove the [hash].filename from vite rollup config, like

...others
build: {
    /** Can slowDown build speed. */
    // sourcemap: isDev,
    outDir,
    minify: isProduction,
    reportCompressedSize: isProduction,
    rollupOptions: {
      output: {
        format: 'esm',
        entryFileNames: 'entry/[name].js',
        chunkFileNames: 'chunks/[name].js',
        assetFileNames: 'src/[name].[ext]',
      },
    },
  },

mLiGuangYuan · 2024-01-05T15:52:00Z

cxtjs-vite-plugin.zip

@mLiGuangYuan is it work with hot reload? Do you have workable solution with additional content script in MAIN world that work with hot reload?

you can try it, in your project, but u need be careful with the variable I set in localStorage, __CRX_EXTEND_ID__, it may have a conflict, don't override it!

MindsightsAI · 2024-01-05T17:17:52Z

@mLiGuangYuan when i am trying to use your zip, all looks fine, but on dev or build process i have that error:

ahwe@user:~/mst-extension$ pnpm run build

> inside-me@ build /home/ahwe/mst-extension
> tsc && vite build

failed to load config from /home/ahwe/mst-extension/vite.config.ts
error during build:
TypeError: (0 , import_cxtjs_vite_plugin2.crx) is not a function
    at config (file:///home/ahwe/mst-extension/vite.config.ts.timestamp-1704474950853-286e3dfc02da4.mjs:110:39)
    at loadConfigFromFile (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:66181:15)
    at async resolveConfig (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:65774:28)
    at async build (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:47926:20)
    at async CAC.<anonymous> (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/cli.js:842:9)
 ELIFECYCLE  Command failed with exit code 1.
ahwe@user:~/mst-extension$

UPD: Same problem after build from source

mLiGuangYuan · 2024-01-06T04:28:15Z

@mLiGuangYuan when i am trying to use your zip, all looks fine, but on dev or build process i have that error:

ahwe@user:~/mst-extension$ pnpm run build

> inside-me@ build /home/ahwe/mst-extension
> tsc && vite build

failed to load config from /home/ahwe/mst-extension/vite.config.ts
error during build:
TypeError: (0 , import_cxtjs_vite_plugin2.crx) is not a function
    at config (file:///home/ahwe/mst-extension/vite.config.ts.timestamp-1704474950853-286e3dfc02da4.mjs:110:39)
    at loadConfigFromFile (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:66181:15)
    at async resolveConfig (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:65774:28)
    at async build (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:47926:20)
    at async CAC.<anonymous> (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/cli.js:842:9)
 ELIFECYCLE  Command failed with exit code 1.
ahwe@user:~/mst-extension$

UPD: Same problem after build from source

this is a package, need import 2 package..

`how to use`

`version`

mLiGuangYuan · 2024-01-06T04:41:25Z

@mLiGuangYuan when i am trying to use your zip, all looks fine, but on dev or build process i have that error:

ahwe@user:~/mst-extension$ pnpm run build

> inside-me@ build /home/ahwe/mst-extension
> tsc && vite build

failed to load config from /home/ahwe/mst-extension/vite.config.ts
error during build:
TypeError: (0 , import_cxtjs_vite_plugin2.crx) is not a function
    at config (file:///home/ahwe/mst-extension/vite.config.ts.timestamp-1704474950853-286e3dfc02da4.mjs:110:39)
    at loadConfigFromFile (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:66181:15)
    at async resolveConfig (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:65774:28)
    at async build (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-68d1a114.js:47926:20)
    at async CAC.<anonymous> (file:///home/ahwe/mst-extension/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/cli.js:842:9)
 ELIFECYCLE  Command failed with exit code 1.
ahwe@user:~/mst-extension$

UPD: Same problem after build from source

if u don't konw how to work, u can use this npm https://www.npmjs.com/package/@belloai/cxtjs-vite-plugin

depressedX · 2024-01-22T11:23:56Z

多个插件在同一个页面上 storage key 相同，会被覆盖吧

mLiGuangYuan · 2024-01-22T11:26:17Z

多个插件在同一个页面上 storage key 相同，会被覆盖吧

I realize that this form of code I'm submitting is up for consideration, and I look forward to your better solutions! can u help to fix it?

Toumash · 2024-06-12T22:32:05Z

packages/vite-plugin/src/client/iife/content-pro-loader.ts

@@ -1,4 +1,6 @@
 declare const __SCRIPT__: string
+
+localStorage.setItem('__CRX_EXTEND_ID__', chrome.runtime.id)


did you try to obtain it using the method described here by the chromium team? It would be cool to not rely on localStorage

// your injected.js. Only works as a first line in the injected script extensionID = document.currentScript.id;

If not then lets try that

Toumash · 2024-06-12T22:39:14Z

packages/vite-plugin/src/node/plugin-manifest.ts

+            for (const {
+              js = [],
+              matches = [],
+              world = 'ISOLATED',


dont we need to pass the world argument into the first if leg? if (config.command === 'serve') {.

I guess it now works in the vite build mode, but does not work in vite (dev) mode

Toumash · 2024-06-12T22:44:22Z

packages/vite-plugin/src/node/contentScripts.ts

+  fileName: string
+  world?: 'ISOLATED' | 'MAIN'
+}): string {
+  const { fileName, world = 'ISOLATED' } = params || {}


i dont get it - this function will never get parameter { world: 'MAIN'}. The only usage this code does not include world parameter

chrome-extension-tools/packages/vite-plugin/src/node/plugin-contentScripts.ts

Line 151 in a4982e3

source: createProLoader({ fileName }),

Toumash · 2024-06-12T23:12:33Z

I would love to test it + help but im not sure how to setup the pnpm workspace (never worked with pnpm and workspaces)

fix: CRXJS does not work with content script in "MAIN" world, link is…

5b68425

…sues: crxjs#695

fix: import file error fix

a66e2a3

Merge branch 'main' into elysion/fix

7f7e8b9

jacksteamdev self-assigned this Jan 7, 2024

jacksteamdev added the vite-plugin Related to Vite plugin label Jan 14, 2024

Merge branch 'main' into elysion/fix

5744c1b

jacksteamdev added the content-script-world Related to main or isolated content script execution context label Jan 14, 2024

Toumash suggested changes Jun 12, 2024

View reviewed changes

Toumash mentioned this pull request Jun 29, 2024

Can not HMR an web-accessible-resources #897

Open

Toumash mentioned this pull request Aug 8, 2024

import of images in content_scripts are resulting in 404 #863

Open

2 tasks

mLiGuangYuan closed this Oct 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: CRXJS does not work with content script in "MAIN" world, link is… #851

fix: CRXJS does not work with content script in "MAIN" world, link is… #851

mLiGuangYuan commented Jan 2, 2024

changeset-bot bot commented Jan 2, 2024 •

edited

Loading

vercel bot commented Jan 2, 2024 •

edited

Loading

MindsightsAI commented Jan 5, 2024

mLiGuangYuan commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 5, 2024

MindsightsAI commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 5, 2024

MindsightsAI commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 6, 2024 •

edited

Loading

mLiGuangYuan commented Jan 6, 2024

depressedX commented Jan 22, 2024

mLiGuangYuan commented Jan 22, 2024

Toumash Jun 12, 2024

Toumash Jun 12, 2024 •

edited

Loading

Toumash Jun 12, 2024

Toumash commented Jun 12, 2024

		@@ -1,4 +1,6 @@
		declare const __SCRIPT__: string

		localStorage.setItem('__CRX_EXTEND_ID__', chrome.runtime.id)

fix: CRXJS does not work with content script in "MAIN" world, link is… #851

fix: CRXJS does not work with content script in "MAIN" world, link is… #851

Conversation

mLiGuangYuan commented Jan 2, 2024

changeset-bot bot commented Jan 2, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Jan 2, 2024 • edited Loading

MindsightsAI commented Jan 5, 2024

mLiGuangYuan commented Jan 5, 2024 • edited Loading

mLiGuangYuan commented Jan 5, 2024

MindsightsAI commented Jan 5, 2024 • edited Loading

mLiGuangYuan commented Jan 5, 2024 • edited Loading

mLiGuangYuan commented Jan 5, 2024

MindsightsAI commented Jan 5, 2024 • edited Loading

mLiGuangYuan commented Jan 6, 2024 • edited Loading

how to use

version

mLiGuangYuan commented Jan 6, 2024

depressedX commented Jan 22, 2024

mLiGuangYuan commented Jan 22, 2024

Toumash Jun 12, 2024

Choose a reason for hiding this comment

Toumash Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Toumash Jun 12, 2024

Choose a reason for hiding this comment

Toumash commented Jun 12, 2024

changeset-bot bot commented Jan 2, 2024 •

edited

Loading

vercel bot commented Jan 2, 2024 •

edited

Loading

mLiGuangYuan commented Jan 5, 2024 •

edited

Loading

MindsightsAI commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 5, 2024 •

edited

Loading

MindsightsAI commented Jan 5, 2024 •

edited

Loading

mLiGuangYuan commented Jan 6, 2024 •

edited

Loading

`how to use`

`version`

Toumash Jun 12, 2024 •

edited

Loading