fix background.type manifest property typescript type #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b296a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the issue using the manifest.json schema instead of the config file https://json.schemastore.org/chrome-manifest.json
The issue arises because the schema you're trying to convert indicates that the type is a string but only allows a specific value ("module"). If you're using this TypeScript type for something that can be either a specific string or a more general string type, you may want to handle it differently.
If you want IntelliSense to work and ensure that "module" is a valid and suggested value, while still allowing other strings, you can use string literal unions in a way that provides IntelliSense but also accepts any string.
Using a branded type approach (to enforce "module" while still allowing any string but guiding IntelliSense):
type Type = "module" | (string & {});closes #914