Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: MsgExec may squeeze multiple message events into a single one #732

Closed
wants to merge 18 commits into from

Conversation

vincentysc
Copy link
Contributor

@vincentysc vincentysc commented Aug 12, 2022

Support inner msg type:

  • MsgSend
  • MsgSetWithdrawAddress
  • MsgWithdrawDelegatorReward
  • MsgWithdrawValidatorCommission
  • MsgFundCommunityPool

Solution: Found that the TxsResult.Events order is following the events emit order. The inner msg parser groups the event by message @type with first in, first out method. In CosmosSDK, the /keeper/msg_server.go of each module shows the event emit order.

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2022

This pull request introduces 1 alert when merging e309714 into 62d39d5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@vincentysc vincentysc closed this Aug 19, 2022
@vincentysc vincentysc deleted the feature/673 branch August 19, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: MsgExec may squeeze multiple message events into a single one
1 participant