Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on uuid package #284

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Remove dependency on uuid package #284

merged 2 commits into from
Feb 7, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Feb 6, 2025

🤔 What's changed?

Use the JavaScript standard crypto.randomUUID() for the UUID generator, rather than the uuid module.

⚡️ What's your motivation?

Reduce dependencies.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title remove uuid dependency Remove dependency on uuid package Feb 6, 2025
@davidjgoss davidjgoss marked this pull request as ready for review February 6, 2025 16:01
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is v similar to how we do in ruby, there's a standard SecureRandom.uuid function we call baked into the stdlib

@luke-hill luke-hill merged commit 1ccfeea into main Feb 7, 2025
38 checks passed
@luke-hill luke-hill deleted the remove-uuid branch February 7, 2025 09:41
davidjgoss added a commit that referenced this pull request Feb 7, 2025
@davidjgoss davidjgoss mentioned this pull request Feb 7, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants