Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BER marshaling to tlv.Tag type and more cleanups #9

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

stv0g
Copy link
Member

@stv0g stv0g commented Nov 28, 2023

No description provided.

@stv0g stv0g self-assigned this Nov 28, 2023
@stv0g stv0g force-pushed the tag-ber-marshaling branch from f994dcd to 0b44712 Compare November 28, 2023 21:46
@stv0g stv0g enabled auto-merge (rebase) November 28, 2023 21:46
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (dfd60b9) 44.28% compared to head (0b44712) 41.15%.

Files Patch % Lines
objects.go 0.00% 69 Missing ⚠️
aid.go 0.00% 18 Missing ⚠️
apdu.go 60.00% 6 Missing ⚠️
encoding/tlv/tlv.go 0.00% 6 Missing ⚠️
encoding/tlv/ber.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   44.28%   41.15%   -3.14%     
==========================================
  Files          23       24       +1     
  Lines        1217     1312      +95     
==========================================
+ Hits          539      540       +1     
- Misses        609      702      +93     
- Partials       69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stv0g stv0g merged commit 159b701 into main Nov 28, 2023
@stv0g stv0g deleted the tag-ber-marshaling branch November 28, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant