Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sdk version in sample app build info #207

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Feb 26, 2025

Changes

  • Replaced update_pubspec_version function call with update-version script to ensure a consistent SDK version update across all relevant files
  • Previously, update_pubspec_version only updated pubspec.yaml causing a mismatch in SDK info displayed in sample app's build info

Screenshots

Before After
before after

@mrehan27 mrehan27 self-assigned this Feb 26, 2025
@mrehan27 mrehan27 requested a review from a team as a code owner February 26, 2025 10:53
Copy link

github-actions bot commented Feb 26, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • amiapp_flutter: ()

Copy link
Contributor

@mahmoud-elmorabea mahmoud-elmorabea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Collaborator

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm why is sample app PR comment broken? 😕

@mrehan27
Copy link
Contributor Author

@Shahroz16 Just checked old PRs and noticed this has likely been broken for a while, probably since we updated the workflow for public builds 😟

@mrehan27 mrehan27 merged commit 94763e8 into main Feb 27, 2025
7 checks passed
@mrehan27 mrehan27 deleted the rehan/sdk-version-fix branch February 27, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants