rebuild golang-custom-analyzer with go v1.22.1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morimoto-cybozu
requested changes
Mar 12, 2024
go.mod
Outdated
| @@ -1,10 +1,7 @@ | |||
| module github.com/cybozu-go/golang-custom-analyzer | |||
|
|
|||
| go 1.19 | |||
| go 1.22.1 | |||
There was a problem hiding this comment.
go 1.22 would be sufficient.
Do you have a reason to specify the patch release?
In terms of functionality, it seems that updating golang.org/x/tools to v0.19.0 is sufficient for using with go 1.22.
We don't necessarily need to update this go directive to the latest.
In terms of the life cycle, it might be good to keep this go 1.20 because we provide golang:1.20 and golang:1.21 as well as golang:1.22.
There was a problem hiding this comment.
@morimoto-cybozu
thx for you comment.
I change golang 1.20 in mod and keep gokang.org/x/tools v0.19.0
morimoto-cybozu
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
コンテナ定期更新で、heatbeat をビルドするのに必要なため、golang/x/tools v0.19.0にアップグレードしました。