Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release.md #5

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Add release.md #5

merged 2 commits into from
Mar 24, 2025

Conversation

012xx
Copy link
Contributor

@012xx 012xx commented Mar 17, 2025

Added due to missing release procedures
I would like to know if there are any md's that I should add to the docs file.
Currently it looks good to have at least this much

@012xx 012xx self-assigned this Mar 17, 2025
@takahiro-yamada takahiro-yamada self-requested a review March 18, 2025 01:08
Copy link

@takahiro-yamada takahiro-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix typos in README.md too?

@012xx 012xx requested a review from takahiro-yamada March 21, 2025 10:24
Copy link

@takahiro-yamada takahiro-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fix but please fix the contents of docs/relese.md too.

Copy link

@takahiro-yamada takahiro-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my comments again? I commented on the contents of release.md
but you only fixed the contents of README.md and the file name of release.md.

Copy link

@takahiro-yamada takahiro-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your patient fix.

@012xx 012xx merged commit 445ff2a into main Mar 24, 2025
1 check passed
@012xx 012xx deleted the docs-update branch March 24, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants