Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): get_list_block_sieve function not callable if sievefilters module is not enabled #1435

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(frontend): get_list_block_sieve function not callable if sievefilters module is not enabled #1435

merged 1 commit into from
Mar 17, 2025

Conversation

christer77
Copy link
Member

@christer77 christer77 changed the title fix:get_list_block_sieve function not callable if sievefilters module… fix(sievefilters):get_list_block_sieve function not callable if sievefilters module… Jan 28, 2025
@christer77 christer77 changed the title fix(sievefilters):get_list_block_sieve function not callable if sievefilters module… fix(other): get_list_block_sieve function not callable if sievefilters module… Jan 28, 2025
@christer77 christer77 force-pushed the get_list_block_sieve_to_sieve_module branch from c1d6a36 to 2551331 Compare February 3, 2025 14:44
@christer77 christer77 changed the title fix(other): get_list_block_sieve function not callable if sievefilters module… fix(frontend): get_list_block_sieve function not callable if sievefilters module… Feb 3, 2025
@mercihabam
Copy link
Member

It looks like some words are being truncated in your pull request title. Make sure to expand the title fully so that all words are visible. If necessary, you can edit the title to be more concise while still conveying the full meaning.

@mercihabam
Copy link
Member

Also, please test every change you make. Does the current code still produce the intended behavior?

@marclaporte
Copy link
Member

@christer77 was unavailable but he is now back.

@christer77 christer77 force-pushed the get_list_block_sieve_to_sieve_module branch 2 times, most recently from 68ba47e to 9928933 Compare March 13, 2025 09:31
@christer77 christer77 changed the title fix(frontend): get_list_block_sieve function not callable if sievefilters module… fix(frontend): get_list_block_sieve function not callable if sievefilters module is not enabled Mar 13, 2025
@christer77 christer77 requested a review from mercihabam March 13, 2025 09:35
@christer77 christer77 force-pushed the get_list_block_sieve_to_sieve_module branch 2 times, most recently from 00f7719 to 34feb38 Compare March 15, 2025 09:32
@christer77 christer77 force-pushed the get_list_block_sieve_to_sieve_module branch from 34feb38 to 0413e81 Compare March 15, 2025 09:34
@mercihabam mercihabam merged commit 6c9af5c into cypht-org:master Mar 17, 2025
6 checks passed
@indridieinarsson indridieinarsson mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mercihabam mercihabam mercihabam left review comments

@Shadow243 Shadow243 Awaiting requested review from Shadow243

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christer77 @mercihabam @marclaporte