Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor role params #355

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Anton-Shutik
Copy link

Updated postgresql_role.

Now it supports postgres ROLE configuration params to accept string values. So you can do:

resource "postgresql_role" "role_with_configuration_parameters" {
	name = "role_with_configuration_parameters"
	statement_timeout = "2h"
	idle_in_transaction_session_timeout = "1d"
  }

Since now, 0 value is not a "placeholder", which will reset to system default value. 0 is a valid param value, which disables timeout (as for statement_timeout, idle_in_transaction_session_timeout )

Also, it is much easier to add new config params for role resource.

Fixes #353

@Anton-Shutik
Copy link
Author

@cyrilgdn Would you mind taking a look, pls ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idle_in_transaction_session_timeout and statement_timeout cannot be set to 0
1 participant