Allow remote IP address to be overridden #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
force-pushed
the
main
branch
3 times, most recently
from
f2c2e47
to
dea1401
Compare
It is useful to be able to override DNS when connecting to your database. libpq supports this, https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-HOSTADDR however Go's pq library does not, lib/pq#860 We thus implement hostaddr ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The postgresql client library provides a "hostaddr" feature, allowing you to override DNS. This is very useful if you wish to use SSL certificate verification but are connecting to your database indirectly.
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-HOSTADDR
This patch adds this feature. The pq library lacks support (lib/pq#860) so I have implemented here inside the proxy wrapper. Please excuse any terrible Go, I am not a regular user!
All the best,
Dave