Add support for postgres stored procedures #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve tested this by creating, updating, and deleting procedures, and it worked perfectly! @cyrilgdn , it would be fantastic if the provider could support stored procedures like it supports functions. |
|
Yeah I mean it's fully unit tested so I would expect it to work, might be some edge cases that I missed though. Would be more than happy to document as well if there was any interest in merging. Unfortunately there has not been any commits to this project in around 6 months so I'm not super hopeful. |
cyrilgdn
force-pushed
the
main
branch
3 times, most recently
from
f2c2e47
to
dea1401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for stored procedures in the provider. Since stored procedures are very similar to functions i based much of this implementation off of the preexisting code for functions.
Also I changed the shebang in some of the bash files so that it works on operating systems where bash is not located at /bin/bash (NixOS for example). I think this should not cause issues on operating systems where bash is located there but if it does cause any issues I am happy to revert that.
Please let me know if you see any issues and I will be happy to fix.