Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where users could input floats into integer columns #428

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

d2fong
Copy link
Member

@d2fong d2fong commented Feb 20, 2025

  • Perform a check when the user inputs values into integer columns in the table browser
  • Reject the value if it is a float.

Testing:

  • Open a network
  • Input a decimal value in a integer column
  • It should not update the value

@d2fong d2fong requested a review from GAOChengzhan February 20, 2025 22:55
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for voluble-rugelach-5a3809 ready!

Name Link
🔨 Latest commit eff350c
🔍 Latest deploy log https://app.netlify.com/sites/voluble-rugelach-5a3809/deploys/67c0ee3c5132dd0008485667
😎 Deploy Preview https://deploy-preview-428--voluble-rugelach-5a3809.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GAOChengzhan
Copy link
Contributor

GAOChengzhan commented Feb 28, 2025

@d2fong Hi Dylan, nice fix for the above bugs but I think there is one left:
I can still set double number to 'list_of_integer' or 'list_of_long' type column

Could you further check on this?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants