Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor 'cancel' and 'confirm' in Export Network Dialog #429

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Anchor 'cancel' and 'confirm' in Export Network Dialog #429

wants to merge 1 commit into from
+322 −334

Conversation

GAOChengzhan
Copy link
Contributor

Ticket: CW_525

Changes Made

  • Move the Cancel and Confirm buttons from the individual export form(svg, png and pdf) components to the root dialog
  • Modify each export form to return their settings and expose a save function so that the root dialog can call each different save function

UI

image

@GAOChengzhan GAOChengzhan requested a review from d2fong February 27, 2025 23:54
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for voluble-rugelach-5a3809 ready!

Name Link
🔨 Latest commit fbf189c
🔍 Latest deploy log https://app.netlify.com/sites/voluble-rugelach-5a3809/deploys/67c0fb1a2a36550008cc7f44
😎 Deploy Preview https://deploy-preview-429--voluble-rugelach-5a3809.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2fong d2fong Awaiting requested review from d2fong

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GAOChengzhan