feat: add Bluesky to Profile Social Links #4052
Conversation
|
@elizabetdev is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
|
|
elizabetdev
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
| viewBox="0 0 24 24" | ||
| > | ||
| <path | ||
| fill="currentColor" |
There was a problem hiding this comment.
Since we have currentColor here we could just use this svg both for mono/color version. What do you think?
There was a problem hiding this comment.
We don't have any coloured SVGs, so we can just use the same for primary and secondary
There was a problem hiding this comment.
Thanks, @ilasw and @omBratteng. Pushed 0628639.
|
Hi @sshanzel, just checking in. Any updates on the API counterpart? |
| @@ -89,6 +91,11 @@ const handlers: Record< | |||
| href: (x) => x, | |||
| label: (x) => withoutProtocol(x), | |||
| }, | |||
| bluesky: { | |||
| icon: <BlueskyIcon />, | |||
| href: (x) => x, | |||
There was a problem hiding this comment.
This needs to prepend the bluesky profile path https://bsky.app/profile/
| @@ -88,6 +89,7 @@ const ProfileIndex = ({ | |||
| youtube: values.youtube, | |||
| linkedin: values.linkedin, | |||
| mastodon: values.mastodon ? withHttps(values.mastodon) : null, | |||
| bluesky: values.bluesky ? withHttps(values.bluesky) : null, | |||
There was a problem hiding this comment.
We should probably not call withHttps here, as it will always add a protocol due to bluesky usernames having domain structures.
There was a problem hiding this comment.
Great work and thank you for contributing!
I left a couple of comments that we should look at before merging.
I've also created a PR for the backend, so as soon as we update here, we should be ready to merge :)
Changes
This PR adds Bluesky to the Profile Social Links.
This feature was requested here:
Fix error with Website and Mastodon fields
Additionally, there was an issue where entering a URL without
httpscaused errors in the Website and Mastodon fields. This happened because theAccountTextFieldwas set as<AccountTextField type="url" />. I’ve removed thetype="url"attribute, aligning it with other fields like Twitter and YouTube, which also don’t specify a type.Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR